From owner-svn-ports-head@FreeBSD.ORG  Wed May 22 20:20:30 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 831FB351;
 Wed, 22 May 2013 20:20:30 +0000 (UTC)
 (envelope-from utisoft@gmail.com)
Received: from mail-ee0-f50.google.com (mail-ee0-f50.google.com [74.125.83.50])
 by mx1.freebsd.org (Postfix) with ESMTP id C25AFB1C;
 Wed, 22 May 2013 20:20:29 +0000 (UTC)
Received: by mail-ee0-f50.google.com with SMTP id c41so1458065eek.9
 for <multiple recipients>; Wed, 22 May 2013 13:20:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc:content-type;
 bh=xzcK8wJIGrlXX2POgozSxFKiSVYVCvO2bFaQvZs1klE=;
 b=0kY64OVY291mnYw0h0t0uCtiqvegJbtmAC2Q/Iqofw47SPjbYsLoHb9pLGEaxLVENO
 /aPH6/JroAUH8IMMq2PD1Wd63D1sA67A5yUvQD08Mr+7VZPnsAJtWh+jOcC++2sGHf7D
 1OgDrsSejWtYqzb2IOXEt1buMBJSwylP/eDVn5nn+H6UwQmU5HmfEFkGUDKhlOys0d0L
 Uv07695lFQU4kRM6IVuX4APfd9heglN5Y62ytDoOPChneSitEWs+HRgPQGc3xu/xqLp4
 vlJcPCnq4nWVY8r7ag7QRosTEXr/+BOBK8HWN5NDC42hRwY92HhmeI6zyJzCaBsKoUo9
 dKRg==
X-Received: by 10.14.172.195 with SMTP id t43mr22944951eel.34.1369254023282;
 Wed, 22 May 2013 13:20:23 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.15.23.76 with HTTP; Wed, 22 May 2013 13:19:52 -0700 (PDT)
In-Reply-To: <20130522192609.GA24645@lorvorc.mips.inka.de>
References: <201305221529.r4MFT9jr046442@svn.freebsd.org>
 <CADLo83_p=ZH8X7_tugsTc_B+4HGwD4arFNisUoshk98LMwpMTA@mail.gmail.com>
 <20130522192609.GA24645@lorvorc.mips.inka.de>
From: Chris Rees <utisoft@gmail.com>
Date: Wed, 22 May 2013 21:19:52 +0100
Message-ID: <CADLo83_XYS9QW=bKn3Xd7Uhy+CFpzY-5X1bZJ6FdxMGbhkZhtg@mail.gmail.com>
Subject: Re: svn commit: r318777 - head/audio/libvorbis
To: Christian Weisgerber <naddy@mips.inka.de>
Content-Type: text/plain; charset=ISO-8859-1
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
 svn-ports-all@freebsd.org,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 22 May 2013 20:20:30 -0000

On 22 May 2013 20:26, Christian Weisgerber <naddy@mips.inka.de> wrote:
> Chris Rees:
>
>> > +OPTIONS_DEFINE=        DOCS
>>
>> Please don't do this; no-one needs an OPTIONS dialog jumping up for
>> something that should be set globally.
>>
>> You don't need DOCS, EXAMPLES, or NLS in OPTIONS_DEFINE if they're the only
>> ones used by the port.
>
> There are plenty of ports with OPTIONS_DEFINE=DOCS and no further
> options.  I changed it (against my personal preference!), because
> it looked like this was the new way.
>
> So what *is* the consensus now?
>
> Either way, the Porter's Handbook is vague.

You are quite right.

There is some discussion about whether to, or not, but the main
suggestion is that docs that require *building* would probably benefit
from this option.

I have some time set aside soon to clarify some stuff in the PH, so
I'd like to get some consensus about this.

Personally I think adding DOCS to OPTIONS_DEFINE at all under most
circumstances is a bad idea, but it appears I'm in a minority here.

Chris