From owner-svn-src-all@FreeBSD.ORG Fri May 22 18:47:51 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3610F105; Fri, 22 May 2015 18:47:51 +0000 (UTC) Received: from id.bluezbox.com (id.bluezbox.com [88.198.91.248]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D78971CC1; Fri, 22 May 2015 18:47:49 +0000 (UTC) Received: from [208.184.220.60] (helo=macbook-air-2.dolby.net) by id.bluezbox.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.77 (FreeBSD)) (envelope-from ) id 1Yvryx-0005Fc-Tn; Fri, 22 May 2015 11:47:46 -0700 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Subject: Re: svn commit: r283275 - head/sys/dev/fdt From: Oleksandr Tymoshenko In-Reply-To: <20150522115315.5e2ba6fa@bender> Date: Fri, 22 May 2015 11:47:12 -0700 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: 7bit Message-Id: <9A12B406-AD79-4DBE-B91E-0C9CB3596E40@freebsd.org> References: <201505220200.t4M20jfi082771@svn.freebsd.org> <20150522115315.5e2ba6fa@bender> To: Andrew Turner X-Mailer: Apple Mail (2.2098) Sender: gonzo@id.bluezbox.com X-Spam-Level: -- X-Spam-Report: Spam detection software, running on the system "id.bluezbox.com", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see The administrator of that system for details. Content preview: > On May 22, 2015, at 3:53 AM, Andrew Turner wrote: > > On Fri, 22 May 2015 02:00:45 +0000 (UTC) > Oleksandr Tymoshenko wrote: > >> Author: gonzo >> Date: Fri May 22 02:00:44 2015 >> New Revision: 283275 >> URL: https://svnweb.freebsd.org/changeset/base/283275 >> >> Log: >> Add helper method fdt_find_child to make access to child nodes >> easier. >> Some FDT nodes have complex properties organized as a child >> sub-nodes (e.g. timing for LCD panel) we need easy way to obtain >> handles for these sub-nodes > > Why is this named fdt_find_child? It's not fdt specific so should be > named something like ofw_bus_find_child and live in > sys/dev/ofw/ofw_bus_subr.c. > > In general we are trying to move away from the fdt_ functions unless > absolutely needed. [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0003] 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: fubar.geek.nz] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 May 2015 18:47:51 -0000 > On May 22, 2015, at 3:53 AM, Andrew Turner wrote: > > On Fri, 22 May 2015 02:00:45 +0000 (UTC) > Oleksandr Tymoshenko wrote: > >> Author: gonzo >> Date: Fri May 22 02:00:44 2015 >> New Revision: 283275 >> URL: https://svnweb.freebsd.org/changeset/base/283275 >> >> Log: >> Add helper method fdt_find_child to make access to child nodes >> easier. >> Some FDT nodes have complex properties organized as a child >> sub-nodes (e.g. timing for LCD panel) we need easy way to obtain >> handles for these sub-nodes > > Why is this named fdt_find_child? It's not fdt specific so should be > named something like ofw_bus_find_child and live in > sys/dev/ofw/ofw_bus_subr.c. > > In general we are trying to move away from the fdt_ functions unless > absolutely needed. I wasn't aware of this. Thanks for pointing out, will change name later today or tomorrow.