From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Mar 29 12:10:59 2008 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3AD8E1065671; Sat, 29 Mar 2008 12:10:59 +0000 (UTC) (envelope-from bms@FreeBSD.org) Received: from out4.smtp.messagingengine.com (out4.smtp.messagingengine.com [66.111.4.28]) by mx1.freebsd.org (Postfix) with ESMTP id 0BBD68FC1F; Sat, 29 Mar 2008 12:10:58 +0000 (UTC) (envelope-from bms@FreeBSD.org) Received: from compute1.internal (compute1.internal [10.202.2.41]) by out1.messagingengine.com (Postfix) with ESMTP id 9AE30E3D42; Sat, 29 Mar 2008 07:52:57 -0400 (EDT) Received: from heartbeat1.messagingengine.com ([10.202.2.160]) by compute1.internal (MEProxy); Sat, 29 Mar 2008 07:52:57 -0400 X-Sasl-enc: HA4COt1S1lAxnVtpV7v5+iGh/csSDlHPoot8O0fHuqBv 1206791577 Received: from empiric.lon.incunabulum.net (82-35-112-254.cable.ubr07.dals.blueyonder.co.uk [82.35.112.254]) by mail.messagingengine.com (Postfix) with ESMTPSA id C35E8A35; Sat, 29 Mar 2008 07:52:56 -0400 (EDT) Message-ID: <47EE2D97.8020404@FreeBSD.org> Date: Sat, 29 Mar 2008 11:52:55 +0000 From: "Bruce M. Simpson" User-Agent: Thunderbird 2.0.0.9 (X11/20080207) MIME-Version: 1.0 To: swp@uni-altai.ru References: <200803290657.m2T6v3tF005906@freefall.freebsd.org> In-Reply-To: <200803290657.m2T6v3tF005906@freefall.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-ports-bugs@FreeBSD.org, linimon@FreeBSD.org Subject: Re: ports/122223: [patch] net/mrouted do not see all network interfaces for me X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Mar 2008 12:10:59 -0000 Hi, Thanks for the patch. linimon@FreeBSD.org wrote: > Old Synopsis: mrouted do not see all network interfaces for me > New Synopsis: [patch] net/mrouted do not see all network interfaces for me > > Responsible-Changed-From-To: freebsd-ports-bugs->bms > Responsible-Changed-By: linimon > Responsible-Changed-When: Sat Mar 29 06:56:15 UTC 2008 > Responsible-Changed-Why: > Fix up synopsis and assign. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=122223 > I'm a bit concerned that it uses sbrk() as that is a very old function, and it has been deprecated in FreeBSD in favour of the mmap based memory allocator. Also it would be better if the code in question were rewritten to use getifaddrs(), as that does most of the legwork involved in getting interface information. Thanks BMS