From owner-freebsd-bugs  Sat Jul 21 22:38:21 2001
Delivered-To: freebsd-bugs@freebsd.org
Received: from vortex.jcmax.com (vortex.jcmax.com [204.69.248.1])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1E8CE37B403; Sat, 21 Jul 2001 22:38:18 -0700 (PDT)
	(envelope-from cr@jcmax.com)
Received: from plasma.jcmax.com (plasma.jcmax.com [204.69.248.13])
	by vortex.jcmax.com (8.9.3/8.9.3) with ESMTP id BAA11832;
	Sun, 22 Jul 2001 01:38:17 -0400 (EDT)
	(envelope-from cr@jcmax.com)
Received: (from cr@localhost)
	by plasma.jcmax.com (8.9.3/8.9.3) id BAA29489;
	Sun, 22 Jul 2001 01:38:17 -0400 (EDT)
	(envelope-from cr@jcmax.com)
Message-ID: <XFMail.010722013817.cr@plasma.jcmax.com>
X-Mailer: XFMail 1.4.0 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <200107220147.f6M1l1558839@freefall.freebsd.org>
Date: Sun, 22 Jul 2001 01:38:17 -0400 (EDT)
X-Face: #'-sNri5f~GKp(6TSg]y8'KgWK*6O@#wF`4T2!#<1tI})wQ_ie{XVBe_3F")&y2vx9Oe~zs
 @{a4BToKV_O!\g*KWu{T,T|)TQ^';&L9RJyAqr?nRxOAie<n]TYAV0q[:DSTb7H1+N^D[<^r\/AWO[
 zt)*do&nxAl5d
Organization: J.C. Max, Inc.
From: Cyrus Rahman <cr@jcmax.com>
To: mike@FreeBSD.org
Subject: Re: bin/18181: Getty can fail to observe :de: specification unle
Cc: freebsd-bugs@FreeBSD.org
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org

On 22-Jul-01 mike@FreeBSD.org wrote:
> Synopsis: Getty can fail to observe :de: specification unless present in
> default
> 
> State-Changed-From-To: open->feedback
> State-Changed-By: mike
> State-Changed-When: Sat Jul 21 18:46:47 PDT 2001
> State-Changed-Why: 
> 
> Does this problem still occur in newer versions of FreeBSD,
> such as 4.3-RELEASE?
> 
> http://www.FreeBSD.org/cgi/query-pr.cgi?pr=18181

As I recall, the problem is that the code (in main.c):

        for (;;) {
                /*
                 * if a delay was specified then sleep for that
                 * number of seconds before writing the initial prompt
                 */
                if (first_sleep && DE) {
                    sleep(DE);
                    /* remove any noise */
                    (void)tcflush(STDIN_FILENO, TCIOFLUSH);
                }
                first_sleep = 0;

                setttymode(tname, 0);

expects to find the correct delay value in DE.  However, this is no longer set
this early in the loop, since the code that would load it with the value
from gettytab:

                gettable(tname, tabent);
                setdefaults();

has been moved into setttymode(), which isn't run until after the test.

Although not elegant, I fixed the problem by adding an extra

                gettable(tname, tabent);
                setdefaults();

at the top of the loop before the first lookup of DE.

Inspection of the latest copy of getty/main.c indicates that the problem has
not been corrected in 1.28.2.3.

Cyrus


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message