From owner-svn-src-all@FreeBSD.ORG Fri May 22 19:57:35 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DF8384A7; Fri, 22 May 2015 19:57:34 +0000 (UTC) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "gold.funkthat.com", Issuer "gold.funkthat.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id A724A14B2; Fri, 22 May 2015 19:57:34 +0000 (UTC) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.14.5/8.14.5) with ESMTP id t4MJvXCE080695 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 22 May 2015 12:57:33 -0700 (PDT) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.14.5/8.14.5/Submit) id t4MJvWOl080694; Fri, 22 May 2015 12:57:32 -0700 (PDT) (envelope-from jmg) Date: Fri, 22 May 2015 12:57:32 -0700 From: John-Mark Gurney To: Cy Schubert Cc: Andrew Turner , Cy Schubert , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r282415 - head/usr.sbin/ntp Message-ID: <20150522195732.GQ37063@funkthat.com> References: <20150517190810.4006b7bb@bender.Home> <201505180053.t4I0rqv4020640@slippy.cwsent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201505180053.t4I0rqv4020640@slippy.cwsent.com> X-Operating-System: FreeBSD 9.1-PRERELEASE amd64 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (gold.funkthat.com [127.0.0.1]); Fri, 22 May 2015 12:57:33 -0700 (PDT) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 May 2015 19:57:35 -0000 Cy Schubert wrote this message on Sun, May 17, 2015 at 17:53 -0700: > In message <20150517190810.4006b7bb@bender.Home>, Andrew Turner writes: > > On Mon, 4 May 2015 12:42:53 +0000 (UTC) > > Cy Schubert wrote: > > > > > Author: cy > > > Date: Mon May 4 12:42:52 2015 > > > New Revision: 282415 > > > URL: https://svnweb.freebsd.org/changeset/base/282415 > > > > > > Log: > > > Restore CPU dependent compile time conditionals. > > > > > > MFC after: 1 month (with r281143 and r282408) > > > > Do you have any plans on fixing this before you MFC it? Specifically: > > * sizeof(char *) == 8 on arm64, powerpc64, and mips64 > > * sizeof(long) == 8 on arm64, powerpc64, and mips64 > > * sizeof(time_t) == 8 on arm, arm64, powerpc64, mips, and mips64 > > * STR_SYSTEM is incorrect on arm, arm64, powerpc64, mips, and mips64, > > however this is now less broken as it was previously also broken on > > i386, and sparc64. > > > > This change is only correct for amd64, i386, and sparc64. > > That is correct. > > > > > I suspect all of the above will also be relevant on ia64. We still have > > support in 10-STABLE for this so should be fixed before an MFC. > > We should support ia64 at least until it's no longer supported in -stable. > > > > > I have heard reports that NTP is broken on some of the above platforms > > so they don't keep very accurate time. Can you fix this, or revert this > > change until a fix can be written. > > Unfortunately -stable is currently as broken as it is in -current. The > quick fix is to add all supported platforms. The other unfortunate fact is > that, scanning the tree for other examples there's more code as broken as > this is. I propose: > > 1. Fix NTP -- I will do this. I have some free time coming up this week to > focus on this. > 2. Identify other parts of the tree needing a little love and either putting > it up on the wiki or in phabricator. > 3. Fix #2 (either me or others as we see fit). > > Alternatively, a common solution for all parts of the tree, if possible. > This is probably a long term solution though. (The purist in me prefers > this but I am practical too.) Why can't we use sizeof for these? -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."