From owner-freebsd-hackers@FreeBSD.ORG  Fri May 29 18:35:17 2009
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2E5131065672
	for <freebsd-hackers@FreeBSD.org>; Fri, 29 May 2009 18:35:17 +0000 (UTC)
	(envelope-from rea-fbsd@codelabs.ru)
Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.177.45])
	by mx1.freebsd.org (Postfix) with ESMTP id D5C158FC1A
	for <freebsd-hackers@FreeBSD.org>; Fri, 29 May 2009 18:35:16 +0000 (UTC)
	(envelope-from rea-fbsd@codelabs.ru)
DomainKey-Signature: a=rsa-sha1; q=dns; c=simple; s=one; d=codelabs.ru;
	h=Received:Date:From:To:Cc:Subject:Message-ID:Reply-To:References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To:Sender;
	b=L0kk78HjDbx1BFZyuZ8H6NKJeUpeXPZ7LiXhAD0CPRPcwMpyJCSgoKc71IuKF/QnD0ud/+Ad/fA/8M5jKb6iYnZT8N6FkQewNcFBb9k3En4ptTa26/SrqgmKdKa/m0JOxo8cJtCS11yUgXmz3FgfQKceeJnfD7yoNedo5UMnyZM=;
Received: from phoenix.codelabs.ru (ppp85-141-65-62.pppoe.mtu-net.ru
	[85.141.65.62])
	by 0.mx.codelabs.ru with esmtpsa (TLSv1:AES256-SHA:256)
	id 1MA6v8-0007l1-6m; Fri, 29 May 2009 22:35:10 +0400
Date: Fri, 29 May 2009 22:35:07 +0400
From: Eygene Ryabinkin <rea-fbsd@codelabs.ru>
To: Dag-Erling Sm??rgrav <des@des.no>
Message-ID: <7Wfi244TRj6h0BU0G5CUnAA6n1Y@BpFm1zkZmHABxHH1eUOcQSRoWTc>
References: <23727599.post@talk.nabble.com> <86prdvipwe.fsf@ds4.des.no>
	<20090527233110.E4243@delplex.bde.org> <86r5yaijef.fsf@ds4.des.no>
	<20090529210855.V1643@besplex.bde.org> <86vdnju9z1.fsf@ds4.des.no>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <86vdnju9z1.fsf@ds4.des.no>
Sender: rea-fbsd@codelabs.ru
Cc: freebsd-hackers@FreeBSD.org, Jakub Lach <jakub_lach@mailplus.pl>,
	Bruce Evans <bde@zeta.org.au>
Subject: Re: FYI Lighttpd 1.4.23 /kernel (trailing '/' on regular file
	symlink) vulnerability
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: rea-fbsd@codelabs.ru
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 29 May 2009 18:35:17 -0000

Fri, May 29, 2009 at 06:53:22PM +0200, Dag-Erling Sm??rgrav wrote:
> Bruce Evans <bde@zeta.org.au> writes:
> > %  	/*
> > %  	 * Get a buffer for the name to be translated, and copy the
> > %  	 * name into the buffer.
> > % @@ -533,6 +536,8 @@
> > %  		if (*cp == '\0') {
> > %  			trailing_slash = 1;
> >
> > I thought at first that this flag can go away.
> 
> I intend to remove it later - I just wanted to get the bug fixed first.
> I'm happy to hear that removing it will fix the two bugs introduced by
> the patch I committed :)

What are those bugs?
-- 
Eygene
 _                ___       _.--.   #
 \`.|\..----...-'`   `-._.-'_.-'`   #  Remember that it is hard
 /  ' `         ,       __.--'      #  to read the on-line manual
 )/' _/     \   `-_,   /            #  while single-stepping the kernel.
 `-'" `"\_  ,_.-;_.-\_ ',  fsc/as   #
     _.-'_./   {_.'   ; /           #    -- FreeBSD Developers handbook
    {_.-``-'         {_/            #