From owner-freebsd-bugs@FreeBSD.ORG  Mon Nov  8 09:40:07 2010
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6884D106567A
	for <freebsd-bugs@hub.freebsd.org>;
	Mon,  8 Nov 2010 09:40:07 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 2532E8FC17
	for <freebsd-bugs@hub.freebsd.org>;
	Mon,  8 Nov 2010 09:40:07 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oA89e73p093299
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 8 Nov 2010 09:40:07 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oA89e7r2093298;
	Mon, 8 Nov 2010 09:40:07 GMT (envelope-from gnats)
Resent-Date: Mon, 8 Nov 2010 09:40:07 GMT
Resent-Message-Id: <201011080940.oA89e7r2093298@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Yui NARUSE <naruse@airemix.jp>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 43D5E1065674
	for <freebsd-gnats-submit@FreeBSD.org>;
	Mon,  8 Nov 2010 09:36:37 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 31DE18FC1D
	for <freebsd-gnats-submit@FreeBSD.org>;
	Mon,  8 Nov 2010 09:36:37 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id oA89aa8U034523
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 8 Nov 2010 09:36:36 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id oA89aaAO034522;
	Mon, 8 Nov 2010 09:36:36 GMT (envelope-from nobody)
Message-Id: <201011080936.oA89aaAO034522@www.freebsd.org>
Date: Mon, 8 Nov 2010 09:36:36 GMT
From: Yui NARUSE <naruse@airemix.jp>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: misc/152042: wrong bufsize of __hdtoa
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Nov 2010 09:40:07 -0000


>Number:         152042
>Category:       misc
>Synopsis:       wrong bufsize of __hdtoa
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 08 09:40:06 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Yui NARUSE
>Release:        8.1-RELEASE
>Organization:
>Environment:
FreeBSD windy.airemix.net 8.1-RELEASE FreeBSD 8.1-RELEASE #1: Sat Jul 24 11:27:04 JST 2010     naruse@windy.airemix.net:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
When ndigits is given for __hdtoa, the bufsize for rv_alloc is too small.
It must add 1 for NUL termination.
>How-To-Repeat:

>Fix:
/usr/src/lib/libc/gdtoa % diff -u _hdtoa.c _hdtoa.c.orig
--- _hdtoa.c    2010-11-08 18:31:46.000000000 +0900
+++ _hdtoa.c.orig       2010-11-08 18:31:44.000000000 +0900
@@ -109,7 +109,7 @@
         * enough space for all the digits.
         */
        bufsize = (ndigits > 0) ? ndigits : SIGFIGS;
-       s0 = rv_alloc(bufsize);
+       s0 = rv_alloc(bufsize+1);
 
        /* Round to the desired number of digits. */
        if (SIGFIGS > ndigits && ndigits > 0) {

>Release-Note:
>Audit-Trail:
>Unformatted: