From owner-svn-src-all@FreeBSD.ORG Fri May 22 20:05:21 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CE26779C for ; Fri, 22 May 2015 20:05:21 +0000 (UTC) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) by mx1.freebsd.org (Postfix) with SMTP id AD81E15F7 for ; Fri, 22 May 2015 20:05:21 +0000 (UTC) Received: from ilsoft.org (unknown [73.34.117.227]) by outbound2.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA; Fri, 22 May 2015 20:05:26 +0000 (UTC) Received: from revolution.hippie.lan (revolution.hippie.lan [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t4MK59a1004225; Fri, 22 May 2015 14:05:09 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1432325109.1252.15.camel@freebsd.org> Subject: Re: svn commit: r282415 - head/usr.sbin/ntp From: Ian Lepore To: John-Mark Gurney Cc: Cy Schubert , Andrew Turner , Cy Schubert , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Fri, 22 May 2015 14:05:09 -0600 In-Reply-To: <20150522195732.GQ37063@funkthat.com> References: <20150517190810.4006b7bb@bender.Home> <201505180053.t4I0rqv4020640@slippy.cwsent.com> <20150522195732.GQ37063@funkthat.com> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.12.10 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 May 2015 20:05:22 -0000 On Fri, 2015-05-22 at 12:57 -0700, John-Mark Gurney wrote: > Cy Schubert wrote this message on Sun, May 17, 2015 at 17:53 -0700: > > In message <20150517190810.4006b7bb@bender.Home>, Andrew Turner writes: > > > On Mon, 4 May 2015 12:42:53 +0000 (UTC) > > > Cy Schubert wrote: > > > > > > > Author: cy > > > > Date: Mon May 4 12:42:52 2015 > > > > New Revision: 282415 > > > > URL: https://svnweb.freebsd.org/changeset/base/282415 > > > > > > > > Log: > > > > Restore CPU dependent compile time conditionals. > > > > > > > > MFC after: 1 month (with r281143 and r282408) > > > > > > Do you have any plans on fixing this before you MFC it? Specifically: > > > * sizeof(char *) == 8 on arm64, powerpc64, and mips64 > > > * sizeof(long) == 8 on arm64, powerpc64, and mips64 > > > * sizeof(time_t) == 8 on arm, arm64, powerpc64, mips, and mips64 > > > * STR_SYSTEM is incorrect on arm, arm64, powerpc64, mips, and mips64, > > > however this is now less broken as it was previously also broken on > > > i386, and sparc64. > > > > > > This change is only correct for amd64, i386, and sparc64. > > > > That is correct. > > > > > > > > I suspect all of the above will also be relevant on ia64. We still have > > > support in 10-STABLE for this so should be fixed before an MFC. > > > > We should support ia64 at least until it's no longer supported in -stable. > > > > > > > > I have heard reports that NTP is broken on some of the above platforms > > > so they don't keep very accurate time. Can you fix this, or revert this > > > change until a fix can be written. > > > > Unfortunately -stable is currently as broken as it is in -current. The > > quick fix is to add all supported platforms. The other unfortunate fact is > > that, scanning the tree for other examples there's more code as broken as > > this is. I propose: > > > > 1. Fix NTP -- I will do this. I have some free time coming up this week to > > focus on this. > > 2. Identify other parts of the tree needing a little love and either putting > > it up on the wiki or in phabricator. > > 3. Fix #2 (either me or others as we see fit). > > > > Alternatively, a common solution for all parts of the tree, if possible. > > This is probably a long term solution though. (The purist in me prefers > > this but I am practical too.) > > Why can't we use sizeof for these? > They are used in a preprocessor context. I'm not sure I understand the comments about various kinds of brokeness. ntpd works just fine on arm and other platforms and has done so for about 10 years on all branches, until a new version was imported a couple weeks ago. Leaving the non-x86 platforms without functioning ntp for weeks is mind-boggling (but I haven't had time to find and fix the problem myself). -- Ian