From owner-svn-ports-head@FreeBSD.ORG  Tue Feb  4 20:09:54 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 227BB38F;
 Tue,  4 Feb 2014 20:09:54 +0000 (UTC)
Received: from mail.issp.ac.ru (mail.issp.ac.ru [77.236.34.3])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 95F511556;
 Tue,  4 Feb 2014 20:09:53 +0000 (UTC)
Received: from [62.63.84.136] [62.63.84.136:7673] (HELO/EHLO
 mercury.ph.man.ac.uk, authenticated with LOGIN)
 by mail.issp.ac.ru with ESMTP/inet id s14K8oZU004682 (using TLSv1/SSLv3,
 with cipher DHE-RSA-AES256-SHA (256 bits), verified NO)
 Wed, 5 Feb 2014 00:08:50 +0400 (MSK)
From: Max Brazhnikov <makc@freebsd.org>
To: Mathieu Arnold <mat@freebsd.org>
Subject: Re: svn commit: r342510 - head/games/cutemaze
Date: Tue, 04 Feb 2014 20:08:50 +0000
Message-ID: <7443970.95gMSVNHBu@mercury.ph.man.ac.uk>
User-Agent: KMail/4.10.5 (FreeBSD/9.2-STABLE; KDE/4.10.5; amd64; ; )
In-Reply-To: <36D80F89A7D5FF449E4FCBDF@ogg.in.absolight.net>
References: <201402041149.s14BnPX0031911@svn.freebsd.org>
 <3033718.ko1yqU3EN4@mercury.ph.man.ac.uk>
 <36D80F89A7D5FF449E4FCBDF@ogg.in.absolight.net>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Feb 2014 20:09:54 -0000

On Tue, 04 Feb 2014 17:31:39 +0100 Mathieu Arnold wrote:
> +--On 4 f=C3=A9vrier 2014 14:36:38 +0000 Max Brazhnikov <makc@freebsd=
.org>
> wrote:
> | On Tue, 04 Feb 2014 14:37:07 +0100 Mathieu Arnold wrote:
> |> +--On 4 f=C3=A9vrier 2014 13:05:39 +0000 Max Brazhnikov <makc@free=
bsd.org>
> |> wrote:
> |> |=20
> |> | This part should be reverted.
> |> | Folks, please *review* what makeplist generates and don't commit=
 it
> |> | blindly.
> |>=20
> |> I for one would love to have feedback on what the evolved makeplis=
t
> |> should do better :-)
> |=20
> | It's way too aggressive for PLIST_SUB and this leads to false
> | substitutions  sometimes. bsd.qt.mk defines a number of QT_*DIR, bu=
t not
> | all of them should  be used (actually it depends on particular port=
).
> | We could help makeplist by telling explicitly which substitutions a=
re
> | right, e.g. by specifying OPTIONS_SUB.
>=20
> Most substitutions are right, I mean, in a perl port, I want PERL_VER=
, and
> SITE_PERL, and PERL5_MAN3, and... there are a few like QT_BINDIR whic=
h
> shouldn't go in it, but it feels more like having a blacklist than a
> whitelist.

Blacklist can be longer than whitelist :).

> Patch welcomes.

I'll think about it. The problem is not specific to Qt ports. I've alre=
ady been
beaten when KDE4_VERSION was improperly used for library version (just
coincidence). In fact, QT_BINDIR could be easily hidden for other ports=
,
but I'd like to see general solution.

Max