From owner-cvs-src@FreeBSD.ORG Tue Feb 28 05:19:43 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C21BE16A420; Tue, 28 Feb 2006 05:19:43 +0000 (GMT) (envelope-from deischen@freebsd.org) Received: from mail.ntplx.net (mail.ntplx.net [204.213.176.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5E9D443D45; Tue, 28 Feb 2006 05:19:43 +0000 (GMT) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.ntplx.net (8.13.5/8.13.5/NETPLEX) with ESMTP id k1S5Jcw0007105; Tue, 28 Feb 2006 00:19:38 -0500 (EST) Date: Tue, 28 Feb 2006 00:19:36 -0500 (EST) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Hajimu UMEMOTO In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.ntplx.net) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/net res_comp.c res_debug.c res_send.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2006 05:19:44 -0000 On Tue, 28 Feb 2006, Hajimu UMEMOTO wrote: > Hi, > > >>>>> On Mon, 27 Feb 2006 22:08:16 +0000 (UTC) > >>>>> Daniel Eischen said: > > deischen> Remove two functions that are not referenced in libc nor > deischen> anywhere else I can find, not visible in and > deischen> which are also local in Solaris libresolv. > > I suspect this change. "They are not referenced in libc nor anywhere > else in our tree" doesn't mean they can be removed, IMHO. Perhaps, it > was backward compatibility thing and obsoleted. But, we lost certain > functionality as they set some flags. It seems that BIND9 still has > res_send_setqhook() and res_send_setrhook(). Well, they're not exported in Solaris 9 either. In our contrib'd bind, they exist but are not referenced by anything within that tree. Bind9 also redefines them to be __res_send_set{qr}hook(), which we do not do. So even if something were expecting to find them, it would have been looking for __res_send_setfoo() which do not exist (even before my changes). -- DE