From owner-freebsd-current Mon Jan 21 5:33:40 2002 Delivered-To: freebsd-current@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id C478037B416 for ; Mon, 21 Jan 2002 05:33:35 -0800 (PST) Received: (from ache@localhost) by nagual.pp.ru (8.11.6/8.11.6) id g0LDXTO35845; Mon, 21 Jan 2002 16:33:29 +0300 (MSK) (envelope-from ache) Date: Mon, 21 Jan 2002 16:33:27 +0300 From: "Andrey A. Chernov" To: Dag-Erling Smorgrav Cc: Mark Murray , current@FreeBSD.ORG Subject: Re: Step5, pam_opie OPIE auth fix for review Message-ID: <20020121133326.GA35793@nagual.pp.ru> References: <20020121000446.GB27206@nagual.pp.ru> <20020121002557.GB27831@nagual.pp.ru> <20020121004906.GA28231@nagual.pp.ru> <20020121025009.GA30673@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.24i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Jan 21, 2002 at 14:07:48 +0100, Dag-Erling Smorgrav wrote: > Dag-Erling Smorgrav writes: > > Umm, you can't use opiechallenge() for that. You're not supposed to > > call opiechallenge() without also calling opieverify() (plus, I think > > opiechallenge() "consumes" a challenge). Use opielookup() instead. > > Even better, opie_haskey() (which is a wrapper around opielookup()). > New patch attached. Yes, this patch works as expected, but I doubt about opie_haskey() status. It looks like non-standard FreeBSD addition since it is in the local opieextra.c file and not in contrib/opie. If you care about machine independance, better use opielookup() directly. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message