From owner-cvs-src@FreeBSD.ORG Tue May 15 06:12:45 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E11E916A402; Tue, 15 May 2007 06:12:45 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id 9CC2813C46C; Tue, 15 May 2007 06:12:45 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id BBE9220A7; Tue, 15 May 2007 08:12:41 +0200 (CEST) X-Spam-Tests: AWL X-Spam-Learn: disabled X-Spam-Score: 0.0/3.0 X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on tim.des.no Received: from dwp.des.no (des.no [80.203.243.180]) by smtp.des.no (Postfix) with ESMTP id ABEA120A6; Tue, 15 May 2007 08:12:41 +0200 (CEST) Received: by dwp.des.no (Postfix, from userid 1001) id 8FF0C5154; Tue, 15 May 2007 08:12:41 +0200 (CEST) From: des@des.no (Dag-Erling =?utf-8?Q?Sm=C3=B8rgrav?=) To: Alexander Leidinger References: <200705131815.l4DIFop9026874@repoman.freebsd.org> <20070514154040.0lofzrgm8kskgog4@webmail.leidinger.net> <86wszbqxbz.fsf@dwp.des.no> <20070514172938.5v4yi78kisokk84s@webmail.leidinger.net> Date: Tue, 15 May 2007 08:12:41 +0200 In-Reply-To: <20070514172938.5v4yi78kisokk84s@webmail.leidinger.net> (Alexander Leidinger's message of "Mon\, 14 May 2007 17\:29\:38 +0200") Message-ID: <861whiy5ra.fsf@dwp.des.no> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile.inc1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2007 06:12:46 -0000 Alexander Leidinger writes: > Dag-Erling Smorgrav writes: > > Alexander Leidinger writes: > > > Why did you remove the echo? > > which echo? about schg? it was completely bogus. > Yes. I don't think so, please explain. It would show up incorrectly if you declined to remove a file. > > feel free to re-add it, but only if you also add logic to check whether > > the file actually has the schg flag set before running chflags. > In the current code it doesn't make sense, and the wording can be > changed to tell that it will remove schg, in case this flag is set. As > you did the change and I don't have time to commit such a change when > I'm back at home (the place where I can make commits), would you > please add the echo again? That would mean an extra line of output for every single file... > > > Why do you redirect stderr of chflags to /dev/null? > > because chflags will complain if your /usr is on a file system which > > does not support flags, such as NFS or ZFS. > But it also removes any other failure message. A more sensible > approach would be to replace the redirection with a "grep -v". No, a more sensible approach would be to only remove schg if it is set. > > > - bug(?): ${DESTDIR} in the rm line > > no, this is intentional, and in fact the original code had it too. > The original code hat it before, but you CD into DESTDIR, so it is not > necessary anymore. Unless someone goofs and adds an absolute path to ObsoleteFiles.inc... which is why I very deliberately left "${DESTDIR}/" in front of the path in the rm command, although I could probably replace it with "./". DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no