From owner-cvs-all@FreeBSD.ORG Sat Oct 4 01:51:51 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AF02716A4B3; Sat, 4 Oct 2003 01:51:51 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1DA7D43FFB; Sat, 4 Oct 2003 01:51:51 -0700 (PDT) (envelope-from jeff@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.9/8.12.9) with ESMTP id h948poXJ071478; Sat, 4 Oct 2003 01:51:50 -0700 (PDT) (envelope-from jeff@repoman.freebsd.org) Received: (from jeff@localhost) by repoman.freebsd.org (8.12.9/8.12.9/Submit) id h948pohE071477; Sat, 4 Oct 2003 01:51:50 -0700 (PDT) (envelope-from jeff) Message-Id: <200310040851.h948pohE071477@repoman.freebsd.org> From: Jeff Roberson Date: Sat, 4 Oct 2003 01:51:50 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/fs/nwfs nwfs_io.c src/sys/fs/smbfs smbfs_io.c src/sys/nfsclient nfs_bio.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Oct 2003 08:51:51 -0000 jeff 2003/10/04 01:51:50 PDT FreeBSD src repository Modified files: sys/fs/nwfs nwfs_io.c sys/fs/smbfs smbfs_io.c sys/nfsclient nfs_bio.c Log: - Remove the backtrace() call from the *_vinvalbuf() functions. Thanks to a stack trace supplied by phk, I now understand what's going on here. The check for VI_XLOCK stops us from calling vinvalbuf once the vnode has been partially torn down in vclean(). It is not clear that this would cause a problem. Document this in nfs_bio.c, which is where the other two filesystems copied this code from. Revision Changes Path 1.31 +1 -5 src/sys/fs/nwfs/nwfs_io.c 1.24 +1 -5 src/sys/fs/smbfs/smbfs_io.c 1.122 +6 -5 src/sys/nfsclient/nfs_bio.c