From owner-freebsd-net@FreeBSD.ORG  Fri Aug 31 16:28:36 2007
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 825FA16A417
	for <freebsd-net@freebsd.org>; Fri, 31 Aug 2007 16:28:36 +0000 (UTC)
	(envelope-from jfvogel@gmail.com)
Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.187])
	by mx1.freebsd.org (Postfix) with ESMTP id 0685413C483
	for <freebsd-net@freebsd.org>; Fri, 31 Aug 2007 16:28:33 +0000 (UTC)
	(envelope-from jfvogel@gmail.com)
Received: by nf-out-0910.google.com with SMTP id k4so701267nfd
	for <freebsd-net@freebsd.org>; Fri, 31 Aug 2007 09:28:12 -0700 (PDT)
DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta;
	h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=UsLVlRnXRXte4iOvW0UesxhpAvkD0P+hAt0TRKXkcRg4g1OlLEY6l42zwnaNo3932azU97RVE3Xohu06t9vqEflKXk76hQs5tT9gZNWCv+2EpmIGF7eFyxyfa0aHlXo5NUfHNiTQsvnN3q9xGl9PpeC2l22FDTJYyn364AB3lvg=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta;
	h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=GOKfm5SJgs2bmtoTSzpMXig9heWeGPV8el08EikRHqhq7gXzw8Xs08g1OHMLXiOWab2mnf66EvDElUNfAlDeRfsWZUDDpPYWEwX4Guhiw3HZZKjq5WX0K3t8NRF09G60TV+MKvi8xxi8GyauIZjOz5NJQiq+kpcIOGxE8zWmDRM=
Received: by 10.82.165.13 with SMTP id n13mr4013157bue.1188577314921;
	Fri, 31 Aug 2007 09:21:54 -0700 (PDT)
Received: by 10.86.81.6 with HTTP; Fri, 31 Aug 2007 09:21:54 -0700 (PDT)
Message-ID: <2a41acea0708310921ic12931bt86e76f3e9fbf5556@mail.gmail.com>
Date: Fri, 31 Aug 2007 09:21:54 -0700
From: "Jack Vogel" <jfvogel@gmail.com>
To: "Tom Judge" <tom@tomjudge.com>
In-Reply-To: <46D7E4B8.4030609@tomjudge.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <2a41acea0708301622j6b4eeab9h62576dcfd1325b0a@mail.gmail.com>
	<46D7E4B8.4030609@tomjudge.com>
Cc: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>,
	Andre Oppermann <andre@freebsd.org>, John Baldwin <jhb@yahoo-inc.com>
Subject: Re: vlan filtering
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 31 Aug 2007 16:28:36 -0000

On 8/31/07, Tom Judge <tom@tomjudge.com> wrote:
> Jack Vogel wrote:
> > I was just working on a bug in the Oplin driver that had me look
> > a bit more at VLAN code than I had previously.
> >
> > FreeBSD has apparently never used the hardware vlan filtering
> > that our hardware can do, is there a systemic reason for this,
> > or has the code lagged in its use of the system?
> >
> > I at least don't understand how the driver is supposed to get
> > the vlan id to set in the filter, am I just unenlightened? :)
> >
> > If this is doable I can add code into em as well as ixgbe.
> >
> > Jack
>
> This isn't really directly related but could be important for some
> users.  If you where to use this would the card handle Q in Q properly
> with the filter on or would there have to be some form of administrative
> option to turn the hardware filter on/off?

I like flexibility, so having it be a feature that could be enabled or not
seems like a good idea to me. Once I understand the situation we'll
see.

Cheers,

Jack