From owner-svn-doc-all@FreeBSD.ORG Mon Feb 18 20:56:53 2013 Return-Path: Delivered-To: svn-doc-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 3E96D603; Mon, 18 Feb 2013 20:56:53 +0000 (UTC) (envelope-from crees@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) by mx1.freebsd.org (Postfix) with ESMTP id 19EE1771; Mon, 18 Feb 2013 20:56:53 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.5/8.14.5) with ESMTP id r1IKuq6K013798; Mon, 18 Feb 2013 20:56:52 GMT (envelope-from crees@svn.freebsd.org) Received: (from crees@localhost) by svn.freebsd.org (8.14.5/8.14.5/Submit) id r1IKuqGr013797; Mon, 18 Feb 2013 20:56:52 GMT (envelope-from crees@svn.freebsd.org) Message-Id: <201302182056.r1IKuqGr013797@svn.freebsd.org> From: Chris Rees Date: Mon, 18 Feb 2013 20:56:52 +0000 (UTC) To: doc-committers@freebsd.org, svn-doc-all@freebsd.org, svn-doc-head@freebsd.org Subject: svn commit: r41011 - head/en_US.ISO8859-1/htdocs/cgi X-SVN-Group: doc-head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-doc-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire doc trees \(except for " user" , " projects" , and " translations" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Feb 2013 20:56:53 -0000 Author: crees (ports committer) Date: Mon Feb 18 20:56:52 2013 New Revision: 41011 URL: http://svnweb.freebsd.org/changeset/doc/41011 Log: Trailing newlines are stripped from any attachments to PRs. This is a problem commonly manifested by distinfo updates, where the file ends up without a newline. Newer versions of GNU patch also choke on such patches. There is probably a more elegant solution than this, but given that GNATS is not going to be with us for too long, we can rely on the behaviour of tools to ignore any trailing newlines if they are added incorrectly [patch, shar]. http://lists.freebsd.org/pipermail/svn-ports-all/2013-February/012069.html Anyone who can show that adding extra newlines to attachments causes breakage is welcome to comment. Bug noticed by: ak, dougb Approved by: maintainer timeout (shaun, five months, multiple emails) Modified: head/en_US.ISO8859-1/htdocs/cgi/query-pr.cgi Modified: head/en_US.ISO8859-1/htdocs/cgi/query-pr.cgi ============================================================================== --- head/en_US.ISO8859-1/htdocs/cgi/query-pr.cgi Mon Feb 18 19:54:21 2013 (r41010) +++ head/en_US.ISO8859-1/htdocs/cgi/query-pr.cgi Mon Feb 18 20:56:52 2013 (r41011) @@ -198,6 +198,7 @@ sub main $patch->filename; print $patch->data; + print "\n"; Exit(); }