From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Sep 18 08:40:09 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 283831065672 for ; Sat, 18 Sep 2010 08:40:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id F0F828FC0C for ; Sat, 18 Sep 2010 08:40:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o8I8e8ub010941 for ; Sat, 18 Sep 2010 08:40:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o8I8e8xH010934; Sat, 18 Sep 2010 08:40:08 GMT (envelope-from gnats) Date: Sat, 18 Sep 2010 08:40:08 GMT Message-Id: <201009180840.o8I8e8xH010934@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Anonymous Cc: Subject: Re: ports/150604: [PATCH] sysutils/superiotool: Fix build with alternate LOCALBASE X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Anonymous List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Sep 2010 08:40:09 -0000 The following reply was made to PR ports/150604; it has been noted by GNATS. From: Anonymous To: Andriy Gapon Cc: Tim Bishop , bug-followup@FreeBSD.org Subject: Re: ports/150604: [PATCH] sysutils/superiotool: Fix build with alternate LOCALBASE Date: Sat, 18 Sep 2010 12:29:02 +0400 Andriy Gapon writes: > Guys, > > if you need that functionality and you tested the patches and they work, then I > approve. Well, I do need the port to respect CC[1] and CFLAGS[2] because I use gcc45 and build all my ports with debug symbols, sometimes with -O0. The tool's output doesn't seem to change after applying my diff. But I don't really use the port. [1] http://www.freebsd.org/doc/en/books/porters-handbook/dads-cc.html [2] http://www.freebsd.org/doc/en/books/porters-handbook/dads-cflags.html > Tim's patch is simple enough for me to see through it, but Anonymous' patch > seems to be more comprehensive. If changing '=' to '?=' makes the build really > honor values set by port's Makefile, then this change seems to be preferable. Nah, there is little difference between hardcoding value into Makefile by REINPLACE_CMD and using `?='.