From owner-freebsd-current@FreeBSD.ORG Tue Jul 9 12:47:59 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 0D8677D6 for ; Tue, 9 Jul 2013 12:47:59 +0000 (UTC) (envelope-from darrenr@freebsd.org) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mx1.freebsd.org (Postfix) with ESMTP id DBAA51DD1 for ; Tue, 9 Jul 2013 12:47:58 +0000 (UTC) Received: from compute2.internal (compute2.nyi.mail.srv.osa [10.202.2.42]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 93B9B20B36 for ; Tue, 9 Jul 2013 08:47:58 -0400 (EDT) Received: from web5.nyi.mail.srv.osa ([10.202.2.215]) by compute2.internal (MEProxy); Tue, 09 Jul 2013 08:47:58 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=message-id:from:to:mime-version :content-transfer-encoding:content-type:subject:reply-to:date :in-reply-to:references; s=smtpout; bh=FF+ZtMPLuibhyLzmmqGtyZA9Y ZM=; b=saOWbGuD9KTK18dju6djd8myiEtm0ztQX1GuhN56oqBLX1umBXRXlX5zQ 6KZoSqNz144KbbCoFfVk01M3jbqEbOv+4Soayyv1xzUzyW4RxVik2ndhvIZwXuyu km42JhMHED7N/F8G8aTj6wzUc3YZ32xXTXOl2W4Sacy7KMwWfU= Received: by web5.nyi.mail.srv.osa (Postfix, from userid 99) id 667471613C9; Tue, 9 Jul 2013 08:47:58 -0400 (EDT) Message-Id: <1373374078.28355.140661253573118.7D24AA96@webmail.messagingengine.com> X-Sasl-Enc: YSYehlF8Od0YnH0wmEQsdXoBcqRT+z3zAF3/Y7Dr33Sj 1373374078 From: Darren Reed To: freebsd-current@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain X-Mailer: MessagingEngine.com Webmail Interface - ajax-cea5092a Subject: Re: Ipfilter pre-Vendor Import Issue Date: Tue, 09 Jul 2013 14:47:58 +0200 In-Reply-To: <51DA85CF.3000401@freebsd.org> References: <201307051838.r65IcL2Q005119@slippy.cwsent.com> <51DA85CF.3000401@freebsd.org> X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: darrenr@freebsd.org List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jul 2013 12:47:59 -0000 On Mon, Jul 8, 2013, at 11:26 AM, Andre Oppermann wrote: > I think the main distinction here is whether the adaptions to > FreeBSD are kept local (resulting in almost a fork) or are fed > upstream so that successive updates require less or no local > changes. > > Having the kernel part in sys/netpfil certainly makes it easier > for kernel people to adjust it to changed realities. > > IIRC ipfilter also has very messy ifdef's all over the place for > every possible ancient version of FreeBSD. This probably should > be cleaned up (and upstreamed) as well. At one point in time, I believed that this was the right thing to do as it allowed new code to work with older systems. That was back when there was little ifdef's... now it is #ifdef hell. However almost nobody cares about this so at some point in the future, I'll join with the masses and new versions or patches will just work with the latest whatever. If the code being imported removed lots of ifdef code that is irrelevant, I don't think anyone will be upset... Cheers, Darren