From owner-svn-ports-head@FreeBSD.ORG  Thu May 23 01:50:15 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id BAFF8A5A; Thu, 23 May 2013 01:50:15 +0000 (UTC)
Date: Thu, 23 May 2013 01:50:15 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Chris Rees <utisoft@gmail.com>
Subject: Re: svn commit: r318777 - head/audio/libvorbis
Message-ID: <20130523015015.GA84302@FreeBSD.org>
References: <201305221529.r4MFT9jr046442@svn.freebsd.org>
 <CADLo83_p=ZH8X7_tugsTc_B+4HGwD4arFNisUoshk98LMwpMTA@mail.gmail.com>
 <20130522192609.GA24645@lorvorc.mips.inka.de>
 <CADLo83_XYS9QW=bKn3Xd7Uhy+CFpzY-5X1bZJ6FdxMGbhkZhtg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CADLo83_XYS9QW=bKn3Xd7Uhy+CFpzY-5X1bZJ6FdxMGbhkZhtg@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
 svn-ports-all@freebsd.org, Christian Weisgerber <naddy@mips.inka.de>,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 23 May 2013 01:50:15 -0000

On Wed, May 22, 2013 at 09:19:52PM +0100, Chris Rees wrote:
> You are quite right.
> 
> There is some discussion about whether to, or not, but the main
> suggestion is that docs that require *building* would probably benefit
> from this option.
> 
> I have some time set aside soon to clarify some stuff in the PH, so
> I'd like to get some consensus about this.
> 
> Personally I think adding DOCS to OPTIONS_DEFINE at all under most
> circumstances is a bad idea, but it appears I'm in a minority here.

I would say that you're right in your desire to get rid of annoying one-item
dialogs with DOCS only option; but the solution would be not to drop them
from OPTIONS_DEFINE, but have a mechanism in bmp that would inhibit dialog
when OPTIONS_DEFINE includes only so-called "global" knobs (DOCS, EXAMPLES,
NLS, IPV6).  This mechanism should be conditional on user's setting inside
/etc/make.conf; maybe it should even eat a list of knobs user does not want
to see in dialog (e.g. always install NLS bits, but ask for DOCS).

This way every port would consistently list all options it supports in the
OPTIONS_DEFINE; global options would finally become truly globally settable
via /etc/make.conf due to centralized handling of them (right now there is
unwanted diversity because some of us list DOCS in OPTIONS_DEFINE, and some
do not); and we would finally stop arguing about it. ;-)

All it takes is just someone(tm) with enough free time to implement this.

./danfe