From owner-cvs-src@FreeBSD.ORG Mon Jun 11 12:50:16 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C141116A41F; Mon, 11 Jun 2007 12:50:16 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 5A56813C457; Mon, 11 Jun 2007 12:50:16 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id A1546472B3; Mon, 11 Jun 2007 08:50:11 -0400 (EDT) Date: Mon, 11 Jun 2007 13:50:11 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Andre Oppermann In-Reply-To: <466CFEC1.6080100@freebsd.org> Message-ID: <20070611134717.D42170@fledge.watson.org> References: <200706110155.l5B1t9d9043150@repoman.freebsd.org> <466CFBE2.1090907@freebsd.org> <20070611074456.GE39661@cdnetworks.co.kr> <466CFEC1.6080100@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: pyunyh@gmail.com, cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Pyun YongHyeon Subject: Re: cvs commit: src/sys/dev/msk if_msk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2007 12:50:16 -0000 On Mon, 11 Jun 2007, Andre Oppermann wrote: >> Is there any way to return EMSGSIZE to upper layer? if_start has return >> type void. Or just dropping the packet if DF bit was not set is enough? > > Dropping the packet is not enough. I forgot the IF queue which separates > the downpath from the encap function... Don't know how you can pass up the > error. Robert wanted to change the drivers queuing model, that would make > it possible. CC'ed. For the past few years I have had plans to move to a queueing model in which ifqueue (or ifaltq) become library routines invoked by the device driver rather than explicit interfaces called above the device driver layer. This would have a number of benefits, including allowing device drivers to use alternative queueing models more easily. Historically, the link layer has been the one returning errors, based on mtu, etc, to the protocol, and not the device driver, but this would allow that to be changed. However, each time I start working on this project, I get lost in a maze of altq macros, so it hasn't happened for 6.0 or 7.0. I'll try again for 8.0 :-) Robert N M Watson Computer Laboratory University of Cambridge