From owner-freebsd-multimedia  Mon Oct 27 07:25:59 1997
Return-Path: <owner-freebsd-multimedia>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id HAA25875
          for multimedia-outgoing; Mon, 27 Oct 1997 07:25:59 -0800 (PST)
          (envelope-from owner-freebsd-multimedia)
Received: from ns1.yes.no (ns1.yes.no [195.119.24.10])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id HAA25863
          for <multimedia@FreeBSD.ORG>; Mon, 27 Oct 1997 07:25:48 -0800 (PST)
          (envelope-from eivind@bitbox.follo.net)
Received: from bitbox.follo.net (bitbox.follo.net [194.198.43.36])
	by ns1.yes.no (8.8.7/8.8.7) with ESMTP id PAA29219;
	Mon, 27 Oct 1997 15:25:28 GMT
Received: (from eivind@localhost)
	by bitbox.follo.net (8.8.6/8.8.6) id QAA02082;
	Mon, 27 Oct 1997 16:25:25 +0100 (MET)
Date: Mon, 27 Oct 1997 16:25:25 +0100 (MET)
Message-Id: <199710271525.QAA02082@bitbox.follo.net>
From: Eivind Eklund <perhaps@yes.no>
To: Joao Carlos Mendes Luis <jonny@coppe.ufrj.br>
CC: multimedia@FreeBSD.ORG
In-reply-to: Joao Carlos Mendes Luis's message of Mon, 27 Oct 1997 11:55:23
	-0200 (EDT)
Subject: Re: Bt848 driver patches
References: <199710270202.DAA00345@bitbox.follo.net>
	<199710271355.LAA22646@gaia.coppe.ufrj.br>
Sender: owner-freebsd-multimedia@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

> 
> #define quoting(Eivind Eklund)
> ...
> // +/* # define BT848_IFORM_F_NTSCM            (0x1) */
> // +  { 525, 22, 480,  910, 135, 754, 640,  780, 30, 0x68, 0x5d, BT848_IFORM_X_XT0 },
> ...
> // +/* # define BT848_IFORM_F_PALM             (0x4) */
> // +  { 625, 32, 576,  910, 186, 922, 640,  780, 25, 0x68, 0x5d, BT848_IFORM_X_XT0 },
> 
> I have not yet tested your code, but PAL/M is just like NTSC when dealing
> with B/W format.   In other words: 525x60 and not 625x50...

OK, is
  { 525, 22, 480,  910, 186, 754, 640,  780, 30, 0x68, 0x5d, BT848_IFORM_X_XT0 },
correct then?  Can you test it?

> //  		case BT848_IFORM_F_NTSCM:
> //  		case BT848_IFORM_F_NTSCJ:
> // -		case BT848_IFORM_F_PALM:
> 
> That's why this line was here...
> 
> //  		case BT848_IFORM_F_PALBDGHI:
> //  		case BT848_IFORM_F_PALN:
> //  		case BT848_IFORM_F_SECAM:
> //  		case BT848_IFORM_F_RSVD:
> // +		case BT848_IFORM_F_PALM:
> 
> ...and not here.  And this part of code works.  I use it everyday.  :)

This part of the code did not work for me; it might have worked for
PAL/M, but not for e.g. PAL/N mode.

However, that part of the code is now changed to only to only set the
Meteor flags to match PAL/NTSC, and calling PAL/M PAL instead of NTSC
seemed reasonable to me.

Eivind.