From owner-svn-src-all@FreeBSD.ORG  Mon May  5 18:55:55 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 68E48797;
 Mon,  5 May 2014 18:55:55 +0000 (UTC)
Received: from theravensnest.org (theraven.freebsd.your.org [216.14.102.27])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cloud.theravensnest.org",
 Issuer "StartCom Class 1 Primary Intermediate Server CA" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 34B601224;
 Mon,  5 May 2014 18:55:54 +0000 (UTC)
Received: from [192.168.0.7] (cpc14-cmbg15-2-0-cust307.5-4.cable.virginm.net
 [82.26.1.52]) (authenticated bits=0)
 by theravensnest.org (8.14.7/8.14.7) with ESMTP id s45ISgYU034184
 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO);
 Mon, 5 May 2014 18:28:44 GMT (envelope-from theraven@FreeBSD.org)
Content-Type: text/plain; charset=koi8-r
Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\))
Subject: Re: svn commit: r265367 - head/lib/libc/regex
From: David Chisnall <theraven@FreeBSD.org>
In-Reply-To: <5367CD77.40909@freebsd.org>
Date: Mon, 5 May 2014 19:28:37 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <B11B5B25-8E05-4225-93D5-3A607332F19A@FreeBSD.org>
References: <201405051641.s45GfFje086423@svn.freebsd.org>
 <5367CD77.40909@freebsd.org>
To: Andrey Chernov <ache@freebsd.org>
X-Mailer: Apple Mail (2.1874)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 "Pedro F. Giffuni" <pfg@FreeBSD.org>, src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 05 May 2014 18:55:55 -0000

On 5 May 2014, at 18:42, Andrey Chernov <ache@freebsd.org> wrote:

> Please don't commit OpenBSD errors. Now you mix calloc() with the
> realloc() for the same variable later which makes calloc() zeroing
> pointless and waste of CPU.

The purpose of calloc() here is not (primarily) to get the zero'd size, =
it's to get the overflow-checking behaviour for calloc. =20

The uses of realloc() later do still potentially overflow, as they =
follow the realloc(pointer, size * sizeof(type)) antipattern. =20

David