From owner-cvs-all@FreeBSD.ORG  Sat Mar 18 23:27:22 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id BA48216A400;
	Sat, 18 Mar 2006 23:27:22 +0000 (UTC)
	(envelope-from csjp@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6372443D48;
	Sat, 18 Mar 2006 23:27:22 +0000 (GMT)
	(envelope-from csjp@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k2INRMRd030741;
	Sat, 18 Mar 2006 23:27:22 GMT
	(envelope-from csjp@repoman.freebsd.org)
Received: (from csjp@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k2INRMJR030740;
	Sat, 18 Mar 2006 23:27:22 GMT (envelope-from csjp)
Message-Id: <200603182327.k2INRMJR030740@repoman.freebsd.org>
From: "Christian S.J. Peron" <csjp@FreeBSD.org>
Date: Sat, 18 Mar 2006 23:27:22 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/sys/kern kern_descrip.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 18 Mar 2006 23:27:22 -0000

csjp        2006-03-18 23:27:22 UTC

  FreeBSD src repository

  Modified files:
    sys/kern             kern_descrip.c 
  Log:
  Back out fd optimization introduced in revision 1.280 as it appears to be
  really breaking things. Simple "close(0); dup(fd)" does not return descriptor
  "0" in some cases. Further, this change also breaks some MAC interactions with
  mac_execve_will_transition().  Under certain circumstances, fdcheckstd() can
  be called in execve(2) causing an assertion that checks to make sure that
  stdin, stdout and stderr reside at indexes 0, 1 and 2 in the process fd table
  to fail, resulting in a kernel panic when INVARIANTS is on.
  
  This should also kill the "dup(2) regression on 6.x" show stopper item on the
  6.1-RELEASE TODO list.
  
  This is a RELENG_6 candidate.
  
  PR:             kern/87208
  Silence from:   des
  MFC after:      1 week
  
  Revision  Changes    Path
  1.292     +2 -4      src/sys/kern/kern_descrip.c