From owner-freebsd-stable@FreeBSD.ORG Tue Oct 21 16:52:21 2008 Return-Path: Delivered-To: stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D022C1065682 for ; Tue, 21 Oct 2008 16:52:21 +0000 (UTC) (envelope-from pluknet@gmail.com) Received: from yx-out-2324.google.com (yx-out-2324.google.com [74.125.44.29]) by mx1.freebsd.org (Postfix) with ESMTP id 815478FC23 for ; Tue, 21 Oct 2008 16:52:21 +0000 (UTC) (envelope-from pluknet@gmail.com) Received: by yx-out-2324.google.com with SMTP id 8so462277yxb.13 for ; Tue, 21 Oct 2008 09:52:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=JXF2iQgkAtfMESRTMHQvxjM+pBaBeILRFZmkE6Y3CMc=; b=TSsRvayz6XJlQ7lKCMkS/yrdWCPmJLUiwe6WWAE5N4PfQe0wDn5WB7gvi/IqJgEDmJ 4WYCQS500XZt5gTnpn3HIJvPIXXi36GZCROTy5a9hLDBdsnbUheda+/MmCxveGivOTi6 lcsaSj7HG8WIXbSuIgUAqi727PLsHddPuYxWQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=ZuY3vNXiNOdHSkKBZDqXpr1bzoKWqkQHGNCmaU+s9eoVVuccK34u/ZNNkw2yEBFQjB TAfGgOrIGdTV38EjQrrOvqtZM0OmnesXL7HirjPu+WmrLb1pfzOpgj+2PrKRs1mOKLXa /477tAVBJhifrfV7valltj50IdINTkmi8sn0A= Received: by 10.90.118.8 with SMTP id q8mr2208907agc.67.1224606633518; Tue, 21 Oct 2008 09:30:33 -0700 (PDT) Received: by 10.90.81.10 with HTTP; Tue, 21 Oct 2008 09:30:33 -0700 (PDT) Message-ID: Date: Tue, 21 Oct 2008 20:30:33 +0400 From: pluknet To: "Jaakko Heinonen" In-Reply-To: <20080929094919.GA6642@a91-153-122-179.elisa-laajakaista.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080928054620.GA80250@k7.mavetju> <48DF4FCA.4070403@sh.cvut.cz> <20080928115401.GU3210@k7.mavetju> <20080929094919.GA6642@a91-153-122-179.elisa-laajakaista.fi> Cc: stable@freebsd.org, V??clav Haisman , current@freebsd.org, Edwin Groothuis Subject: Re: Request for testing - top 3.8b1 in the base system X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Oct 2008 16:52:21 -0000 2008/9/29 Jaakko Heinonen : > On 2008-09-28, Edwin Groothuis wrote: >> > Swap: 3000M Total, 181M Used, 2819M Free, 6% Inuse >> > sysctlnametomib: No such file or directory >> > >> > And no processes. >> >> I didn't expect it not to work on 6.x, I will play around with it >> tomorrow to see if it makes sense. > > According to svn log kern.cp_times sysctl was added in r174070 and MFCd > after 6.3/7.0 release. > As a simple workaround: Index: top/freebsd-top-3.8b1-A/usr.bin/top/machine.c =================================================================== --- top/freebsd-top-3.8b1-A/usr.bin/top/machine.c (revision 5702) +++ top/freebsd-top-3.8b1-A/usr.bin/top/machine.c (working copy) @@ -513,6 +513,12 @@ while (mp->name != NULL) { len = MAXMIBLEN; +#if __FreeBSD_version < 604000 + if (!strcmp(mp->name, "kern.cp_times")) { + mp++; + continue; + } +#endif if (sysctlnametomib(mp->name, mp->mib, &len) == -1) { message_error(" sysctlnametomib: %s", strerror(errno)); -- wbr, pluknet