From owner-freebsd-current@FreeBSD.ORG Sat Jun 19 15:56:55 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6E60016A4CE for ; Sat, 19 Jun 2004 15:56:55 +0000 (GMT) Received: from mailhost.stack.nl (vaak.stack.nl [131.155.140.140]) by mx1.FreeBSD.org (Postfix) with ESMTP id C1E1F43D2F for ; Sat, 19 Jun 2004 15:56:54 +0000 (GMT) (envelope-from jilles@stack.nl) Received: from turtle.stack.nl (turtle.stack.nl [IPv6:2001:610:1108:5010::132]) by mailhost.stack.nl (Postfix) with ESMTP id 5BC031F006; Sat, 19 Jun 2004 17:55:58 +0200 (CEST) Received: by turtle.stack.nl (Postfix, from userid 1677) id 1CCBA1CD0E; Sat, 19 Jun 2004 17:55:57 +0200 (CEST) Date: Sat, 19 Jun 2004 17:55:57 +0200 From: Jilles Tjoelker To: Poul-Henning Kamp Message-ID: <20040619155557.GA96090@stack.nl> References: <61609.1087632958@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <61609.1087632958@critter.freebsd.dk> X-Operating-System: FreeBSD 5.2.1-RELEASE-p8 i386 User-Agent: Mutt/1.5.6i cc: current@freebsd.org Subject: Re: [REVIEW] move tty lock/initial up in the stack X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jun 2004 15:56:55 -0000 On Sat, Jun 19, 2004 at 10:15:58AM +0200, Poul-Henning Kamp wrote: > It adds two new flags to stty(1): -i and -l to manipulate the initial > and lock states and eliminates the tty[il]d# and cua[il]a# devices. > Subsequently I would like to move the tty/cua split up as well. > Index: bin/stty/stty.c > =================================================================== > RCS file: /home/ncvs/src/bin/stty/stty.c,v > retrieving revision 1.22 > diff -u -r1.22 stty.c > --- bin/stty/stty.c 6 Apr 2004 20:06:53 -0000 1.22 > +++ bin/stty/stty.c 18 Jun 2004 11:36:57 -0000 > @@ -60,15 +60,17 @@ ... > while (optind < argc && > strspn(argv[optind], "-aefg") == strlen(argv[optind]) && This needs to be changed to "-aefgil". This is possible because there are no arguments starting with "-" and containing only "[aefgil]" in the rest. (This also means you can't do "-f/dev/ttyxxx".) > - (ch = getopt(argc, argv, "aef:g")) != -1) > + (ch = getopt(argc, argv, "aef:gil")) != -1) > switch(ch) { > case 'a': /* undocumented: POSIX compatibility */ Not really related, but stty -a has been properly documented for a long time ;-) -- Jilles Tjoelker