From owner-freebsd-hackers@FreeBSD.ORG Thu Sep 25 12:09:58 2003 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CCF2E16A4B3 for ; Thu, 25 Sep 2003 12:09:58 -0700 (PDT) Received: from mail.speakeasy.net (mail8.speakeasy.net [216.254.0.208]) by mx1.FreeBSD.org (Postfix) with ESMTP id 006E943F93 for ; Thu, 25 Sep 2003 12:09:58 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 3749 invoked from network); 25 Sep 2003 19:09:56 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 25 Sep 2003 19:09:56 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h8PJ9W6Y029795; Thu, 25 Sep 2003 15:09:37 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20030925135456.GK90598@cicely12.cicely.de> Date: Thu, 25 Sep 2003 15:09:35 -0400 (EDT) From: John Baldwin To: Bernd Walter X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: steve@Watt.COM cc: hackers@freebsd.org Subject: Re: PCI bridges & interrupts X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Sep 2003 19:09:58 -0000 On 25-Sep-2003 Bernd Walter wrote: > On Wed, Sep 24, 2003 at 06:17:43PM -0400, John Baldwin wrote: >> >> On 24-Sep-2003 M. Warner Losh wrote: >> > You might want to make sure that you have an up to date stable. There >> > was a fix to the PCI bridge interrupt swizzle. >> >> Ah yes, that's true. However, it doesn't seem that his interrupt is >> being routed, but I could be wrong. Also, there is another bug in the >> $PIR handling that I committed at BSDCon that also might fix the >> problem. > > Is your $PIR fix for the everthing gets IRQ4 case? Well, when using 'pci_cfgintr_linked' we would get things wrong. > lcvs diff -u -kk -r1.104 -r1.105 pci_cfgreg.c Index: pci_cfgreg.c =================================================================== RCS file: /usr/cvs/src/sys/i386/pci/pci_cfgreg.c,v retrieving revision 1.104 retrieving revision 1.105 diff -u -r1.104 -r1.105 --- pci_cfgreg.c 2 Aug 2003 05:14:17 -0000 1.104 +++ pci_cfgreg.c 10 Sep 2003 06:00:53 -0000 1.105 @@ -445,7 +445,7 @@ * table entry */ irq = pci_cfgintr_search(pe, oe->pe_bus, oe->pe_device, - j, pin); + j + 1, pin); if (irq != PCI_INVALID_IRQ) return(irq); } -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/