From owner-cvs-all@FreeBSD.ORG  Sat Apr 14 12:46:57 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id EFA4616A402;
	Sat, 14 Apr 2007 12:46:57 +0000 (UTC)
	(envelope-from simon@zaphod.nitro.dk)
Received: from mx.nitro.dk (zarniwoop.nitro.dk [83.92.207.38])
	by mx1.freebsd.org (Postfix) with ESMTP id A082513C4B0;
	Sat, 14 Apr 2007 12:46:57 +0000 (UTC)
	(envelope-from simon@zaphod.nitro.dk)
Received: from zaphod.nitro.dk (unknown [192.168.3.39])
	by mx.nitro.dk (Postfix) with ESMTP id 1C03D2D4B98;
	Sat, 14 Apr 2007 12:46:56 +0000 (UTC)
Received: by zaphod.nitro.dk (Postfix, from userid 3000)
	id DDCE71142C; Sat, 14 Apr 2007 14:46:55 +0200 (CEST)
Date: Sat, 14 Apr 2007 14:46:55 +0200
From: "Simon L. Nielsen" <simon@FreeBSD.org>
To: Stanislav Sedov <stas@FreeBSD.org>
Message-ID: <20070414124654.GB1687@zaphod.nitro.dk>
References: <200704141016.l3EAGqIs023798@repoman.freebsd.org>
	<1176546388.54822.11.camel@ikaros.oook.cz>
	<1176546959.54822.14.camel@ikaros.oook.cz>
	<20070414154246.89ad2946.stas@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070414154246.89ad2946.stas@FreeBSD.org>
User-Agent: Mutt/1.5.11
Cc: cvs-src@FreeBSD.org, pav@FreeBSD.org, cvs-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: cvs commit: src/contrib/top top.X top.c top.h src/usr.bin/top
	machine.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Apr 2007 12:46:58 -0000

On 2007.04.14 15:42:46 +0400, Stanislav Sedov wrote:
> On Sat, 14 Apr 2007 12:35:59 +0200
> Pav Lucistnik <pav@FreeBSD.org> mentioned:
> >
> > Also, is the width cut-off technical problem, or is it fixable?
> > See http://people.freebsd.org/~pav/top.png for what I mean.
> >
> 
> Well, they allocate a static buffer of 128 byte lenght, so the result
> doesn't fit into it. Also, there's buffer overrun, since sprintf is
> used, not snprintf.

So, if a user sets a very long proctitle now and some other user runs
top with the new feature the buffer will overflow?

-- 
Simon L. Nielsen