From owner-freebsd-multimedia@FreeBSD.ORG Wed Nov 25 19:56:12 2009 Return-Path: Delivered-To: multimedia@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E4C87106568B for ; Wed, 25 Nov 2009 19:56:12 +0000 (UTC) (envelope-from morganw@chemikals.org) Received: from warped.bluecherry.net (unknown [IPv6:2001:440:eeee:fffb::2]) by mx1.freebsd.org (Postfix) with ESMTP id 61C5D8FC17 for ; Wed, 25 Nov 2009 19:56:12 +0000 (UTC) Received: from volatile.chemikals.org (adsl-67-221-140.shv.bellsouth.net [98.67.221.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by warped.bluecherry.net (Postfix) with ESMTPSA id 4A92798AB615; Wed, 25 Nov 2009 13:56:11 -0600 (CST) Received: from localhost (morganw@localhost [127.0.0.1]) by volatile.chemikals.org (8.14.3/8.14.3) with ESMTP id nAPJu6mi065867; Wed, 25 Nov 2009 13:56:07 -0600 (CST) (envelope-from morganw@chemikals.org) Date: Wed, 25 Nov 2009 13:56:06 -0600 (CST) From: Wes Morgan To: Gea-Suan Lin In-Reply-To: <20091125161409.4F42E7E81B@colo-p.gslin.org> Message-ID: References: <20091125161409.4F42E7E81B@colo-p.gslin.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII X-Virus-Scanned: clamav-milter 0.95.2 at warped X-Virus-Status: Clean Cc: multimedia@freebsd.org Subject: Re: [PATCH] multimedia/x264: update to 0.0.20091124 X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Nov 2009 19:56:13 -0000 On Thu, 26 Nov 2009, Gea-Suan Lin wrote: > >> Submitter-Id: current-users >> Originator: Gea-Suan Lin >> Organization: >> Confidential: no >> Synopsis: [PATCH] multimedia/x264: update to 0.0.20091124 >> Severity: non-critical >> Priority: low >> Category: ports >> Class: update >> Release: FreeBSD 7.2-RELEASE-p3 i386 >> Environment: > System: FreeBSD colo-p.gslin.org 7.2-RELEASE-p3 FreeBSD 7.2-RELEASE-p3 #0: Sat Aug 22 10:48:39 CST 2009 >> Description: > - Update to 0.0.20091124 > > Port maintainer (multimedia@FreeBSD.org) is cc'd. > > Generated with FreeBSD Port Tools 0.99 >> How-To-Repeat: >> Fix: > > --- x264-0.0.20091124.patch begins here --- > diff -ruN --exclude=CVS /usr/ports/multimedia/x264/Makefile /home/staff/gslin/work/ports/x264/Makefile > --- /usr/ports/multimedia/x264/Makefile 2009-11-23 04:28:29.000000000 +0800 > +++ /home/staff/gslin/work/ports/x264/Makefile 2009-11-26 00:13:16.000000000 +0800 > @@ -6,7 +6,7 @@ > # $Id: Makefile 30 2006-10-30 22:15:26Z buhnux $ > > PORTNAME= x264 > -PORTVERSION= 0.0.20081218 > +PORTVERSION= 0.0.20091124 > CATEGORIES= multimedia > MASTER_SITES= http://downloads.videolan.org/pub/videolan/x264/snapshots/ \ > http://samples.mplayerhq.hu/yuv4mpeg2/:pgo > @@ -16,7 +16,7 @@ > EXTRACT_ONLY= ${PORTNAME}-snapshot-${PORTVERSION:S/0.0.//}-2245${EXTRACT_SUFX} > > MAINTAINER= multimedia@FreeBSD.org > -COMMENT?= Multimedia library and tool for encoding H.264/AVC video streams > +COMMENT= Multimedia library and tool for encoding H.264/AVC video streams > > BUILD_DEPENDS= yasm>=0.6.0:${PORTSDIR}/devel/yasm > > @@ -36,7 +36,7 @@ > > CONFIGURE_ARGS+= --extra-cflags="${CPPFLAGS} ${CFLAGS} -fPIC -I${LOCALBASE}/include -I${LOCALBASE}/include" \ > --extra-ldflags="${LDFLAGS} -L${LOCALBASE}/lib -L${LOCALBASE}/lib" \ > - --enable-shared > + --enable-shared --disable-asm I'm pretty certain that this will not work on amd64. The gcc internal "log2f" function won't be picked up. See this email for a fix: http://lists.freebsd.org/pipermail/freebsd-multimedia/2009-March/009819.html Would it also be possible to add knobs for enabling the internal assembler and adding dependencies on both binutils and gcc 4.4 from ports? I've been using a snapshot built this way for about 2 weeks now doing some pretty heavy encoding and have no problems other than the log2f patch.