From owner-svn-src-all@FreeBSD.ORG Sun Sep 20 14:11:33 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BA86D106566B; Sun, 20 Sep 2009 14:11:33 +0000 (UTC) (envelope-from dds@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id A8BAD8FC15; Sun, 20 Sep 2009 14:11:33 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n8KEBX0k058932; Sun, 20 Sep 2009 14:11:33 GMT (envelope-from dds@svn.freebsd.org) Received: (from dds@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n8KEBXnn058929; Sun, 20 Sep 2009 14:11:33 GMT (envelope-from dds@svn.freebsd.org) Message-Id: <200909201411.n8KEBXnn058929@svn.freebsd.org> From: Diomidis Spinellis Date: Sun, 20 Sep 2009 14:11:33 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r197356 - in head: tools/regression/usr.bin/sed usr.bin/sed X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Sep 2009 14:11:33 -0000 Author: dds Date: Sun Sep 20 14:11:33 2009 New Revision: 197356 URL: http://svn.freebsd.org/changeset/base/197356 Log: Allow [ to be used as a delimiter. Pointed by: Marius Strobl Obtained from: Apple Modified: head/tools/regression/usr.bin/sed/multitest.t head/usr.bin/sed/compile.c Modified: head/tools/regression/usr.bin/sed/multitest.t ============================================================================== --- head/tools/regression/usr.bin/sed/multitest.t Sun Sep 20 13:54:27 2009 (r197355) +++ head/tools/regression/usr.bin/sed/multitest.t Sun Sep 20 14:11:33 2009 (r197356) @@ -432,6 +432,15 @@ u2/g' lines1 # POSIX does not say that this should work, # but it does for GNU, BSD, and SunOS mark '8.17' ; $SED -e 's/[/]/Q/' lines1 + + COMMENT='[ as an s delimiter and its escapes' + mark '8.18' ; $SED -e 's[_[X[' lines1 + # This is a matter of interpretation + # POSIX 1003.1, 2004 says "Within the BRE and the replacement, + # the BRE delimiter itself can be used as a *literal* character + # if it is preceded by a backslash + mark '8.19' ; sed 's/l/[/' lines1 | $SED -e 's[\[.[X[' + mark '8.20' ; sed 's/l/[/' lines1 | $SED -e 's[\[.[X\[[' } test_error() Modified: head/usr.bin/sed/compile.c ============================================================================== --- head/usr.bin/sed/compile.c Sun Sep 20 13:54:27 2009 (r197355) +++ head/usr.bin/sed/compile.c Sun Sep 20 14:11:33 2009 (r197356) @@ -387,7 +387,7 @@ compile_delimited(char *p, char *d) errx(1, "%lu: %s: newline can not be used as a string delimiter", linenum, fname); while (*p) { - if (*p == '[') { + if (*p == '[' && *p != c) { if ((d = compile_ccl(&p, d)) == NULL) errx(1, "%lu: %s: unbalanced brackets ([])", linenum, fname); continue;