From owner-cvs-all@FreeBSD.ORG  Sun Dec 28 14:00:36 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4E05916A4D0
	for <cvs-all@FreeBSD.org>; Sun, 28 Dec 2003 14:00:36 -0800 (PST)
Received: from rootlabs.com (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id 3F41343D45
	for <cvs-all@FreeBSD.org>; Sun, 28 Dec 2003 14:00:32 -0800 (PST)
	(envelope-from nate@rootlabs.com)
Received: (qmail 9955 invoked by uid 1000); 28 Dec 2003 22:00:33 -0000
Date: Sun, 28 Dec 2003 14:00:33 -0800 (PST)
From: Nate Lawson <nate@root.org>
To: "Brian F. Feldman" <green@FreeBSD.org>
In-Reply-To: <200312261826.hBQIQkAX060681@green.bikeshed.org>
Message-ID: <20031228135955.J9675@root.org>
References: <200312261826.hBQIQkAX060681@green.bikeshed.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: Sam Leffler <sam@errno.com>
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: cvs-src@FreeBSD.org
Subject: Re: cvs commit: src/sys/net if.c 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Dec 2003 22:00:36 -0000

On Fri, 26 Dec 2003, Brian F. Feldman wrote:
> Sam Leffler <sam@errno.com> wrote:
> > On Friday 26 December 2003 10:09 am, Brian Feldman wrote:
> > > green       2003/12/26 10:09:35 PST
> > >
> > >   FreeBSD src repository
> > >
> > >   Modified files:
> > >     sys/net              if.c
> > >   Log:
> > >   Don't truncate the interface name in ifunit().  It's now possible to
> > > query "very long interface names", e.g.:
> > >   ndis_atheros0: flags=8847<UP,BROADCAST,DEBUG,RUNNING,SIMPLEX,MULTICAST>
> > > mtu 1500
> >
> > I'm not sure this works out well as I believe user-level apps like netstat
> > assume interface names are short max-lengthed strings.  I've been using the
> > ndis stuff (great work btw) and was thinking instead that it would be nice to
> > customize the device by specifying the name at config time.
> >
> > I think you need to discuss changes like this before committing them.
>
> They are still short max-length strings.  ifunit() wasn't accounting for the
> "dev/" it was appending when it searches for a given interface, so it was
> limiting things to IFNAMSIZE - 4 accidentally.

Hmmm, then shouldn't you use "dev/" instead of "net"?

+       char namebuf[IFNAMSIZ + sizeof("net")]; /* XXX net_cdevsw.d_name */

-Nate