From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Jun 17 07:50:06 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E64C81065673 for ; Fri, 17 Jun 2011 07:50:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B763E8FC17 for ; Fri, 17 Jun 2011 07:50:05 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p5H7o5DR073880 for ; Fri, 17 Jun 2011 07:50:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p5H7o5jc073878; Fri, 17 Jun 2011 07:50:05 GMT (envelope-from gnats) Resent-Date: Fri, 17 Jun 2011 07:50:05 GMT Resent-Message-Id: <201106170750.p5H7o5jc073878@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dmitry Marakasov Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 591151065672 for ; Fri, 17 Jun 2011 07:41:07 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from smtp.timeweb.ru (smtp.timeweb.ru [92.53.116.15]) by mx1.freebsd.org (Postfix) with ESMTP id 108B48FC0C for ; Fri, 17 Jun 2011 07:41:06 +0000 (UTC) Received: from [213.148.20.85] (helo=hive.panopticon) by smtp.timeweb.ru with esmtpsa (TLSv1:CAMELLIA256-SHA:256) (Exim 4.71) (envelope-from ) id 1QXTft-0002fG-4j for FreeBSD-gnats-submit@freebsd.org; Fri, 17 Jun 2011 11:41:05 +0400 Received: from hades.panopticon (hades.panopticon [192.168.0.32]) by hive.panopticon (Postfix) with ESMTP id 22B51B84D for ; Fri, 17 Jun 2011 11:41:04 +0400 (MSD) Received: by hades.panopticon (Postfix, from userid 1000) id F0DA3B823; Fri, 17 Jun 2011 11:41:03 +0400 (MSD) Message-Id: <20110617074103.F0DA3B823@hades.panopticon> Date: Fri, 17 Jun 2011 11:41:03 +0400 (MSD) From: Dmitry Marakasov To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/157936: [bsd.port.mk] add LDFLAGS support X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Dmitry Marakasov List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2011 07:50:06 -0000 >Number: 157936 >Category: ports >Synopsis: [bsd.port.mk] add LDFLAGS support >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Jun 17 07:50:05 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Dmitry Marakasov >Release: FreeBSD 8.2-RELEASE i386 >Organization: >Environment: System: FreeBSD hades.panopticon 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Tue Mar 8 09:48:52 MSK 2011 root@hades.panopticon:/async/obj/usr/src/sys/HADES i386 >Description: Not long ago, CPPFLAGS support was added to bsd.port.mk. Strange thing, though, is that LDFLAGS support was not added along with it, as these two options are usually used/changed together. Handling them both will make it possible to remove CONFIGURE_ENV= lines from many ports, which is good as those are error-prone hacks (common mistage is CONFIGURE_ENV=LDFLAGS+=...), and will also allow more flexibility, which we may need soon as new LTO-capable compilers may require certain linker-only options and an ability for the user and/or ports system to change them. >How-To-Repeat: >Fix: --- bsd.port.mk.patch begins here --- Index: bsd.port.mk =================================================================== RCS file: /home/amdmi3/projects/freebsd/FreeBSD.cvs/ports/Mk/bsd.port.mk,v retrieving revision 1.684 diff -u -r1.684 bsd.port.mk --- bsd.port.mk 6 Jun 2011 05:53:51 -0000 1.684 +++ bsd.port.mk 17 Jun 2011 07:29:45 -0000 @@ -2277,6 +2277,7 @@ MOTIFLIB="${MOTIFLIB}" LIBDIR="${LIBDIR}" \ CC="${CC}" CFLAGS="${CFLAGS}" \ CPP="${CPP}" CPPFLAGS="${CPPFLAGS}" \ + LDFLAGS="${LDFLAGS}" \ CXX="${CXX}" CXXFLAGS="${CXXFLAGS}" \ MANPREFIX="${MANPREFIX}" @@ -3779,6 +3780,7 @@ ${SET_LATE_CONFIGURE_ARGS} \ if ! ${SETENV} CC="${CC}" CPP="${CPP}" CXX="${CXX}" \ CFLAGS="${CFLAGS}" CPPFLAGS="${CPPFLAGS}" CXXFLAGS="${CXXFLAGS}" \ + LDFLAGS="${LDFLAGS}" \ INSTALL="/usr/bin/install -c ${_BINOWNGRP}" \ INSTALL_DATA="${INSTALL_DATA}" \ INSTALL_LIB="${INSTALL_LIB}" \ --- bsd.port.mk.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: