From owner-freebsd-ports@FreeBSD.ORG Wed Jun 22 08:57:26 2011 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8B9DC1065828; Wed, 22 Jun 2011 08:57:26 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 42AD08FC1B; Wed, 22 Jun 2011 08:57:25 +0000 (UTC) Received: by iyb11 with SMTP id 11so692059iyb.13 for ; Wed, 22 Jun 2011 01:57:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:from :date:x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=Z5hD937OpovFdVRvyEaltmXZANqRPIWsNfeyKwzTZ3c=; b=RH1/zApn47xub88E4ezhBMlCaeX1nkqKTHtg8MhY9uVK8ZfwxmsIt9o8/66IbnyowC LYFUm4VKIZXEWXcAs0QqZF5m5SqiZZZbAc7p57yGlM8nqA9PBIp+YLa/qfjIL8qm42Sv 0B+NW3kryJ5DxI55z1mJwtVkkWnTU8/EQfvAk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=AXWSrtU/r2Nf0grhi7P65ddetsSecTq7Itgxsx9gPsDMP+3slLx0X90hvcqnmCVe8g 2R+Q4pmExy7GaakFRETEOGG9YxwRpLogxJAP6MJrr92sy3E7/ihqZqGziXymlY8klLXX dwz7LNL0/ZUWZ1WZN9OoEZVlWdi7gfFoDeq/Y= Received: by 10.43.43.199 with SMTP id ud7mr462824icb.450.1308733045323; Wed, 22 Jun 2011 01:57:25 -0700 (PDT) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.231.49.193 with HTTP; Wed, 22 Jun 2011 01:56:55 -0700 (PDT) In-Reply-To: <20110622064224.GB94185@FreeBSD.org> References: <20110621214013.6cc4760e@heavennet.ru> <20110622020048.GA83940@FreeBSD.org> <20110622064224.GB94185@FreeBSD.org> From: Chris Rees Date: Wed, 22 Jun 2011 09:56:55 +0100 X-Google-Sender-Auth: s45555J27Te_P9D070Ze8ps8mng Message-ID: To: Alexey Dokuchaev Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: ports@freebsd.org, "Ilya A. Arkhipov" , kwm@freebsd.org Subject: Re: OpenTTD X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2011 08:57:26 -0000 2011/6/22 Alexey Dokuchaev : > On Wed, Jun 22, 2011 at 10:33:14AM +0400, Ilya A. Arkhipov wrote: >> Ok i rewrite patch and do with argument, and write patch to portlint ;) > > Wow, if you could write a patch to portlint that is would correctly sugge= st > that MAINTAINER/COMMENT/LICENSE should be grouped together, and FOO_DEPEN= DS > would be closed to USE_BAR knobs, I'd be very grateful! > > Just to make myself clear on this issue: COMMENT/LICENSE are general > software information, FOO_DEPENDS and USE_BAR knobs both specify > dependencies (that is, package-related stuff). =A0I believe that it does = not > make sence to mix them, hence LICENSE should be defined before _DEPENDS, = not > after. > I agree 110% with this. It confused me a while ago when I started to use LICENSE, but I think the general acceptance is that we should have: PORTNAME PORTVERSION etc MAINTAINER COMMENT LICENSE So license in a separate block; you can have several license lines making the MAINTAINER/COMMENT block unnecessarily large. Not too sure about keeping _DEPENDS with USE; there're additional variables often set with USE, perhaps a block for _DEPENDS and then USE etc underneath? (could follow with USERS/GROUPS). Example: PORTNAME PORTVERSION etc MAINTAINER COMMENT LICENSE LIB_DEPENDS=3D BUILD_DEPENDS=3D RUN_DEPENDS=3D USE_FOO FOO_ARGS USE_BAR USERS GROUPS Chris