From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Oct 9 18:20:28 2003 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0ABDA16A4BF for ; Thu, 9 Oct 2003 18:20:28 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8251C43FAF for ; Thu, 9 Oct 2003 18:20:27 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h9A1KRFY040733 for ; Thu, 9 Oct 2003 18:20:27 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h9A1KRYR040732; Thu, 9 Oct 2003 18:20:27 -0700 (PDT) (envelope-from gnats) Date: Thu, 9 Oct 2003 18:20:27 -0700 (PDT) Message-Id: <200310100120.h9A1KRYR040732@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Adam Weinberger Subject: Re: ports/57823: PATCH: obey portlint warnings X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Adam Weinberger List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Oct 2003 01:20:28 -0000 The following reply was made to PR ports/57823; it has been noted by GNATS. From: Adam Weinberger To: Shannon -jj Behrens Cc: FreeBSD-gnats-submit@FreeBSD.org, kbyanc@FreeBSD.org Subject: Re: ports/57823: PATCH: obey portlint warnings Date: 9 Oct 2003 21:12:53 -0400 >> (10.09.2003 @ 2055 PST): Shannon -jj Behrens said, in 1.5K: << > diff ./Makefile /usr/ports/net/p5-Net-Radius/Makefile > 10d9 > < PORTREVISION= 1 > 18c18 > < BUILD_DEPENDS= ${SITE_PERL}/${PERL_ARCH}/Digest/MD5.pm:${PORTSDIR}/security/p5-Digest-MD5 > --- > > BUILD_DEPENDS= ${LOCALBASE}/lib/perl5/site_perl/${PERL_VER}/${PERL_ARCH}/Digest/MD5.pm:${PORTSDIR}/security/p5-Digest-MD5 > 26c26 > < ${FIND} ${WRKDIR} -type f | xargs perl -pi -e "s:\r::g" > --- > > find ${WRKDIR} -type f | xargs perl -pi -e "s:\r::g" >> end of "ports/57823: PATCH: obey portlint warnings" from Shannon -jj Behrens << I think you ran diff with the arguments reversed. At least, I hope so. Bumping PORTREVISION is unnecessary here, and the find line should be: ${FIND} ${WRKSRC} -type f | ${XARGS} ${PERL5} -pe -e "s:\r::g" # Adam -- Adam Weinberger vectors.cx >> adam@vectors.cx >> http://www.vectors.cx magnesium.net << adamw@magnesium.net << http://www.magnesium.net/~adamw FreeBSD >> adamw@FreeBSD.org >> http://people.freebsd.org/~adamw #vim:set ts=8: 8-char tabs prevent tooth decay.