From owner-freebsd-ports-bugs@FreeBSD.ORG  Thu Oct  9 18:30:13 2003
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id AB41416A4B3
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Thu,  9 Oct 2003 18:30:13 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 57F4043FEC
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Thu,  9 Oct 2003 18:30:11 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h9A1UBFY041363
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Thu, 9 Oct 2003 18:30:11 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h9A1UB93041361;
	Thu, 9 Oct 2003 18:30:11 -0700 (PDT)
	(envelope-from gnats)
Date: Thu, 9 Oct 2003 18:30:11 -0700 (PDT)
Message-Id: <200310100130.h9A1UB93041361@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
From: Shannon -jj Behrens <jj@nttmcl.com>
Subject: Re: ports/57823: PATCH: obey portlint warnings
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Shannon -jj Behrens <jj@nttmcl.com>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Oct 2003 01:30:13 -0000

The following reply was made to PR ports/57823; it has been noted by GNATS.

From: Shannon -jj Behrens <jj@nttmcl.com>
To: Adam Weinberger <adamw@FreeBSD.org>
Cc: FreeBSD-gnats-submit@FreeBSD.org, kbyanc@FreeBSD.org
Subject: Re: ports/57823: PATCH: obey portlint warnings
Date: Thu, 9 Oct 2003 18:21:51 -0700

 On Thu, Oct 09, 2003 at 09:12:53PM -0400, Adam Weinberger wrote:
 > >> (10.09.2003 @ 2055 PST): Shannon -jj Behrens said, in 1.5K: <<
 > > diff ./Makefile /usr/ports/net/p5-Net-Radius/Makefile
 > > 10d9
 > > < PORTREVISION=	1
 > > 18c18
 > > < BUILD_DEPENDS=	${SITE_PERL}/${PERL_ARCH}/Digest/MD5.pm:${PORTSDIR}/security/p5-Digest-MD5
 > > ---
 > > > BUILD_DEPENDS=	${LOCALBASE}/lib/perl5/site_perl/${PERL_VER}/${PERL_ARCH}/Digest/MD5.pm:${PORTSDIR}/security/p5-Digest-MD5
 > > 26c26
 > > < 	${FIND} ${WRKDIR} -type f | xargs perl -pi -e "s:\r::g"
 > > ---
 > > > 	find ${WRKDIR} -type f | xargs perl -pi -e "s:\r::g"
 > >> end of "ports/57823: PATCH: obey portlint warnings" from Shannon -jj Behrens <<
 > 
 > I think you ran diff with the arguments reversed. At least, I hope so.
 
 You're right.
 
 > Bumping PORTREVISION is unnecessary here, and the find line should be:
 > ${FIND} ${WRKSRC} -type f | ${XARGS} ${PERL5} -pe -e "s:\r::g"
 
 Excellent.  It's obvious that you're paying attention, whereas I was
 just blindly following portlint.
 
 Thanks,
 -jj
 
 -- 
 Research is the best place to be:  you work your buns off, and if it
 works you're a hero; if it doesn't, well--nobody else has done it yet
 either, so you're still a valiant nerd.