From owner-cvs-all@FreeBSD.ORG Fri Dec 17 12:52:35 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 447C416A4CE; Fri, 17 Dec 2004 12:52:35 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 29C9943D53; Fri, 17 Dec 2004 12:52:34 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id iBHCqWsk091951; Fri, 17 Dec 2004 14:52:32 +0200 (EET) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 08832-20; Fri, 17 Dec 2004 14:52:29 +0200 (EET) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id iBHCq0ef091910 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 17 Dec 2004 14:52:01 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id iBHCq5xE061329; Fri, 17 Dec 2004 14:52:05 +0200 (EET) (envelope-from ru) Date: Fri, 17 Dec 2004 14:52:00 +0200 From: Ruslan Ermilov To: Nik Clayton Message-ID: <20041217125200.GA61177@ip.net.ua> References: <200412161955.iBGJtvIO060191@repoman.freebsd.org> <20041217112053.GK17158@clan.nothing-going-on.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="RnlQjJ0d97Da+TV1" Content-Disposition: inline In-Reply-To: <20041217112053.GK17158@clan.nothing-going-on.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2004 12:52:35 -0000 --RnlQjJ0d97Da+TV1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Nik, On Fri, Dec 17, 2004 at 11:20:54AM +0000, Nik Clayton wrote: > On Thu, Dec 16, 2004 at 07:55:57PM +0000, Ruslan Ermilov wrote: > > Previous revision didn't fix all cases. For example, > > testing for variables that are always defined (e.g., > > "make -V CC") would still print a false warning. Fix > > this by only passing a submake the MAKEOBJDIRPREFIX=3D* > > argument if it was present. As a result, we loose > > the check for -DMAKEOBJDIRPREFIX, or an esoteric > > "MAKEOBJDIRPREFIX =3D foo" (with embedded spaces), but > > these are unorthodox enough to not care about them. > > =20 > > The make(1) bug mentioned in the previous revision > > was just fixed in make/main.c,v 1.109. >=20 > Do you have test cases for these issues? They should be added to=20 > tools/regression/usr.bin/make. >=20 I know about tools/regression/usr.bin/make (as could be seen =66rom my commits there). Unfortunately, the testcase for this bug is somewhat hard to exploit. On my i386 testbox, I could only reproduce it under certain conditions, like the current working directory, etc. On amd64, it was always easier (I don't know why). The testcase may be as simple as this: $ env MAKEFLAGS=3D"-f /dev/null" make -V /nonexistent make: cannot open /nonexistent. $ echo $? 2 The bug is that the value of "/nonexistent" will replace the value of "/dev/null". Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --RnlQjJ0d97Da+TV1 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBwtZwqRfpzJluFF4RAnYrAJwO2JulZKOnqboh36cwROPi2r0QjQCgm58Q sGJONEkK7Iwaf6s2oukH7l0= =o3Wk -----END PGP SIGNATURE----- --RnlQjJ0d97Da+TV1--