From owner-svn-src-all@freebsd.org  Mon Apr  4 15:10:07 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id DA025B02806;
 Mon,  4 Apr 2016 15:10:07 +0000 (UTC)
 (envelope-from eric@vangyzen.net)
Received: from smtp.vangyzen.net (hotblack.vangyzen.net [199.48.133.146])
 by mx1.freebsd.org (Postfix) with ESMTP id A968B1047;
 Mon,  4 Apr 2016 15:10:06 +0000 (UTC)
 (envelope-from eric@vangyzen.net)
Received: from sweettea.beer.town (unknown [76.164.8.130])
 by smtp.vangyzen.net (Postfix) with ESMTPSA id C32EA564B7;
 Mon,  4 Apr 2016 10:09:59 -0500 (CDT)
Subject: Re: svn commit: r297501 - head/usr.sbin/pciconf
To: Oliver Pinter <oliver.pinter@hardenedbsd.org>,
 John Baldwin <jhb@freebsd.org>
References: <201604020159.u321xr2V087305@repo.freebsd.org>
 <CAPQ4ffv5=Lzy-nHka13PtyWDRD0zaeuB=+MB7jcQUpp-JFrtrQ@mail.gmail.com>
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 Hans Petter Selasky <hps@selasky.org>
From: Eric van Gyzen <eric@vangyzen.net>
X-Enigmail-Draft-Status: N1110
Message-ID: <570283C3.1020702@vangyzen.net>
Date: Mon, 4 Apr 2016 10:09:55 -0500
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
MIME-Version: 1.0
In-Reply-To: <CAPQ4ffv5=Lzy-nHka13PtyWDRD0zaeuB=+MB7jcQUpp-JFrtrQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.21
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Apr 2016 15:10:08 -0000

On 04/02/2016 04:49, Oliver Pinter wrote:
>
>     +       printf(" slot %d", (cap & PCIEM_SLOT_CAP_PSN) >> 19);
>     +       printf(" power limit %d mW", slot_power(cap));
>     +       if (cap & PCIEM_SLOT_CAP_HPC)
>     +               printf(" HotPlug(%s)", sta & PCIEM_SLOT_STA_PDS ?
>     "present" :
>     +                   "empty");
>     +       if (cap & PCIEM_SLOT_CAP_HPS)
>     +               printf(" surprise");
>
>
> What is this surprise string or state? Or is this a forgotten debug
> string?

>From the "PCI EXPRESS BASE SPECIFICATION, REV. 3.1a":

"""
6.7.2.9.  Port Capabilities and Slot Information Registers

Hot-Plug Surprise (Slot Capabilities) – When Set, this bit indicates
that adapter removal from the
system without any prior notification is permitted for the associated
form factor.
"""

However, John committed this on April 1, so it /could/ be an easter egg,
intended for Hans Petter Selasky.  ;-)

>     +       if (cap & PCIEM_SLOT_CAP_APB)
>     +               printf(" Attn Button");
>     +       if (cap & PCIEM_SLOT_CAP_PCP)
>     +               printf(" PC(%s)", ctl & PCIEM_SLOT_CTL_PCC ? "on"
>     : "off");
>     +       if (cap & PCIEM_SLOT_CAP_MRLSP)
>     +               printf(" MRL(%s)", sta & PCIEM_SLOT_STA_MRLSS ?
>     "open" :
>     +                   "closed");
>      }
>