From owner-svn-src-stable@FreeBSD.ORG Wed Sep 2 16:12:45 2009 Return-Path: Delivered-To: svn-src-stable@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 71C66106566C; Wed, 2 Sep 2009 16:12:45 +0000 (UTC) (envelope-from kensmith@cse.Buffalo.EDU) Received: from phoebe.cse.buffalo.edu (phoebe.cse.buffalo.edu [128.205.32.89]) by mx1.freebsd.org (Postfix) with ESMTP id 2D8478FC0A; Wed, 2 Sep 2009 16:12:44 +0000 (UTC) Received: from [128.205.32.76] (bauer.cse.buffalo.edu [128.205.32.76]) (authenticated bits=0) by phoebe.cse.buffalo.edu (8.14.1/8.13.7) with ESMTP id n82FaIAI089945 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 2 Sep 2009 11:36:27 -0400 (EDT) (envelope-from kensmith@cse.buffalo.edu) From: Ken Smith To: Doug Barton In-Reply-To: <4A9E8BBE.9060000@FreeBSD.org> References: <200909020212.n822C7Il078379@svn.freebsd.org> <8497dc1520e5fe6b2b3727d5fb92f358.squirrel@www.jr-hosting.nl> <4A9E8BBE.9060000@FreeBSD.org> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-oEGsUu8QJtWkVXcXRaIs" Organization: U. Buffalo CSE Department Date: Wed, 02 Sep 2009 11:36:15 -0400 Message-Id: <1251905775.24711.32.camel@bauer.cse.buffalo.edu> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 FreeBSD GNOME Team Port X-DCC-Buffalo.EDU-Metrics: phoebe.cse.buffalo.edu 1335; Body=0 Fuz1=0 Fuz2=0 Cc: remko@elvandar.org, svn-src-stable@FreeBSD.org, svn-src-all@FreeBSD.org, Alfred Perlstein , src-committers@FreeBSD.org, svn-src-stable-8@FreeBSD.org Subject: Re: svn commit: r196746 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/usb dev/usb/input dev/xen/xenpci X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Sep 2009 16:12:45 -0000 --=-oEGsUu8QJtWkVXcXRaIs Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Wed, 2009-09-02 at 08:14 -0700, Doug Barton wrote: > That said, for RELENG_8 commits during the freeze re@ did ask in one > of their many messages about commit approvals to paste the complete > commit message in the MFC. So, bad Alfred, no cookie. :) Just for clarification... We ask that you send your complete *proposed commit message* in your *approval request*. We didn't say that your commit message needs to include all of the text from the commit to head. So, bad Doug, no cookie. :-) FWIW my preference is, as usual, somewhere in between the two extremes. Duplicating a lengthy commit message in a merge is overkill but in those cases a short (one sentence max) summary of what changed being in the merge commit message is helpful. For example when looking through the commits for release notes fodder it can help. It also helps people who take the peer review of commits being done seriously to get the warm fuzzy feeling that the merge wasn't an accidental mis-merge (by seeing that the code seems to match the brief description). --=20 Ken Smith - From there to here, from here to | kensmith@cse.buffalo.edu there, funny things are everywhere. | - Theodore Geisel | --=-oEGsUu8QJtWkVXcXRaIs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkqekOQACgkQ/G14VSmup/YWfQCfSnHu68c34PDsv+MGUw5LCkvs aAcAn3qSX4C2+6izZMbGIwsmKfvVZkRq =kamy -----END PGP SIGNATURE----- --=-oEGsUu8QJtWkVXcXRaIs--