From owner-freebsd-ports-bugs@freebsd.org Sat Aug 4 22:29:11 2018 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 832C21055B43 for ; Sat, 4 Aug 2018 22:29:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 1D4768BEE4 for ; Sat, 4 Aug 2018 22:29:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id D62141055B42; Sat, 4 Aug 2018 22:29:10 +0000 (UTC) Delivered-To: ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9BE681055B41 for ; Sat, 4 Aug 2018 22:29:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 261048BEE3 for ; Sat, 4 Aug 2018 22:29:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 6ADC91E617 for ; Sat, 4 Aug 2018 22:29:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w74MT9Hi028138 for ; Sat, 4 Aug 2018 22:29:09 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w74MT9Bd028137 for ports-bugs@FreeBSD.org; Sat, 4 Aug 2018 22:29:09 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 230354] emulators/libdsk: Update to 1.4.2 Date: Sat, 04 Aug 2018 22:29:09 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tobik@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Aug 2018 22:29:11 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230354 Tobias Kortkamp changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tobik@freebsd.org --- Comment #3 from Tobias Kortkamp --- Comment on attachment 195847 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D195847 Update +.for i in ${DOCS} + ${INSTALL_DATA} ${WRKSRC}/doc/${i} ${STAGEDIR}${DOCSDIR} +.endfor More readable and better since it runs ${INSTALL_DATA} only once: cd ${WRKSRC}/doc && ${INSTALL_DATA} ${DOCS} ${STAGEDIR}${DOCSDIR} +DOCS=3D apridisk.html cfi.html libdsk.lyx libdsk.pdf \ + libdsk.txt libdskrc.sample protocol.txt README TODO Just use PORTDOCS here instead and remove the PLIST_FILES bit below again. +.if ${PORT_OPTIONS:MDOCS} +PLIST_FILES+=3D ${PORTDOCS}${DOCSDIR}/README ${PORTDOCS}${DOCSDIR}/TODO \ + ${PORTDOCS}${DOCSDIR}/apridisk.html ${PORTDOCS}${DOCSDIR}/cfi.html \ + ${PORTDOCS}${DOCSDIR}/libdsk.lyx ${PORTDOCS}${DOCSDIR}/libdsk.pdf \ + ${PORTDOCS}${DOCSDIR}/libdsk.txt ${PORTDOCS}${DOCSDIR}/libdskrc.sample \ + ${PORTDOCS}${DOCSDIR}/protocol.txt +.endif This is not necessary when using PORTDOCS, but you should read up on options helpers variables either way [1]. Variables should always be set before any targets [2]. [1] https://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html= #options-variables [2] https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html --=20 You are receiving this mail because: You are the assignee for the bug.=