From owner-freebsd-stable@FreeBSD.ORG  Thu Aug 19 17:26:17 2010
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by hub.freebsd.org (Postfix) with ESMTP id 23BE6106566B;
	Thu, 19 Aug 2010 17:26:17 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
From: Jung-uk Kim <jkim@FreeBSD.org>
To: pluknet <pluknet@gmail.com>
Date: Thu, 19 Aug 2010 13:26:08 -0400
User-Agent: KMail/1.6.2
References: <201007141414.o6EEEUx9014690@lurza.secnetix.de>
	<4C6D5E31.9000701@icyb.net.ua>
	<AANLkTi=hZC9gL2xF2oD9w5ApgZ11LyRf1WbE=3YZuHef@mail.gmail.com>
In-Reply-To: <AANLkTi=hZC9gL2xF2oD9w5ApgZ11LyRf1WbE=3YZuHef@mail.gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201008191326.09822.jkim@FreeBSD.org>
Cc: freebsd-stable@freebsd.org, Andriy Gapon <avg@icyb.net.ua>
Subject: Re: 8.1-PRERELEASE: CPU packages not detected correctly
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Aug 2010 17:26:17 -0000

On Thursday 19 August 2010 12:56 pm, pluknet wrote:
> On 19 August 2010 20:39, Andriy Gapon <avg@icyb.net.ua> wrote:
> > on 10/08/2010 19:55 pluknet said the following:
> >> On 16 July 2010 19:47, Jung-uk Kim <jkim@freebsd.org> wrote:
> >>> The patch should apply fine on both
> >>> sys/amd64/amd64/mp_machdep.c and sys/i386/i386/mp_machdep.c.
> >>>
> >>> http://people.freebsd.org/~jkim/mp_machdep2.diff
> >>
> >> Hi.
> >>
> >> Just checked on Xen HVM with 3 cores.
> >> 1) 8.1 unmodified:
> >> FreeBSD/SMP: Multiprocessor System Detected: 3 CPUs
> >> FreeBSD/SMP: 1 package(s) x 3 core(s)
> >>
> >> 2) 8.1 + patch
> >> FreeBSD/SMP: Multiprocessor System Detected: 3 CPUs
> >> FreeBSD/SMP: 0 package(s) x 1 core(s) x 32 HTT threads
> >> WARNING: Non-uniform processors.
> >> WARNING: Using suboptimal topology.
> >
> > Can you debug, e.g. with printfs, what exactly goes wrong?
> > I wonder if in this case code follows some unusual/unexpected
> > path.
>
> Sorry, I'm a bit busy right now.
> I hope to debug this somewhere in the next week.
>
> > BTW, could you please also provide CPU name/model/features as
> > detected by the kernel?
>
> Sure.
> CPU: Intel(R) Xeon(R) CPU           E5520  @ 2.27GHz (2763.12-MHz
> 686-class CPU) Origin = "GenuineIntel"  Id = 0x106a5  Family = 6 
> Model = 1a  Stepping = 5
> Features=0x1781fbbf<FPU,VME,DE,PSE,TSC,MSR,MCE,CX8,APIC,SEP,MTRR,PG
>E,MCA,CMOV,PAT,MMX,FXSR,SSE,SSE2,HTT>
> Features2=0x80982201<SSE3,SSSE3,CX16,SSE4.1,SSE4.2,POPCNT,<b31>>
> TSC: P-state invariant
> real memory  = 4194304000 (4000 MB)
> avail memory = 3932786688 (3750 MB)
> ACPI APIC Table: <Xen HVM>
> FreeBSD/SMP: Multiprocessor System Detected: 3 CPUs
> FreeBSD/SMP: 0 package(s) x 1 core(s) x 32 HTT threads
>  cpu0 (BSP): APIC ID:  0
>  cpu1 (AP/HT): APIC ID:  2
>  cpu2 (AP/HT): APIC ID:  4
>
> Just a thought.
>  # HTT might somehow correlate with current maxcpus limit (32).

One thing I am not sure is whether those CPUID instructions are 
executed on *real* CPUs or translated in HVM.  On top of that, I am 
not even sure they will be executed on *correct* cores.  I bet they 
won't.  If that's the case, we should add exception for virtualized 
environment as we did for default HZ.

Jung-uk Kim