From owner-svn-ports-head@FreeBSD.ORG Sat Jan 12 20:40:18 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id EC0078D0; Sat, 12 Jan 2013 20:40:18 +0000 (UTC) (envelope-from r.c.ladan@gmail.com) Received: from mail-ea0-f172.google.com (mail-ea0-f172.google.com [209.85.215.172]) by mx1.freebsd.org (Postfix) with ESMTP id 3C4C48E0; Sat, 12 Jan 2013 20:40:17 +0000 (UTC) Received: by mail-ea0-f172.google.com with SMTP id f13so1199080eaa.3 for ; Sat, 12 Jan 2013 12:40:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; bh=UKsrCib0jmRRnypMhqMfc2nTqC/K8CxxYlIqBB2awD0=; b=t0cCAGHVFSg8v98ZdCZRxd4BDA2VuExXIIPkaVhz53KsUEW+/FfRYgea5SyR2WaM6D ElCrfq5CKXXOXwPpoPSP2q130FoNFK5KoEHIP+Zx4bpTZIdD4beD3ZIT481o9jnTMiVo 9H/TnH6fEchWW6B0avsOtTXKrbWGl4rInAfCF/krMq6uZbBwphhTpPqubAEjCtSO93bz V10h9WsyIRW2OHZ8bqXuI+wWWo3invysRxa1qAZFIxLNSE7fyqCUeZLuqj1A/GaSyCOg CyCbWn03Zwg4VssK4Zx8LiXwd9qO3w5LL/gZd2tjqbhWnBJsM82rxKgAkaOtvoCsyUWq FKPw== X-Received: by 10.14.2.196 with SMTP id 44mr213546575eef.25.1358023209848; Sat, 12 Jan 2013 12:40:09 -0800 (PST) Received: from [192.168.123.167] (136-206-ftth.onsbrabantnet.nl. [88.159.206.136]) by mx.google.com with ESMTPS id b49sm14331132eem.16.2013.01.12.12.40.07 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 12 Jan 2013 12:40:08 -0800 (PST) Sender: =?UTF-8?Q?Ren=C3=A9_Ladan?= Message-ID: <50F1CA26.4050604@freebsd.org> Date: Sat, 12 Jan 2013 21:40:06 +0100 From: =?ISO-8859-1?Q?Ren=E9_Ladan?= User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Cy Schubert Subject: Re: svn commit: r310215 - in head/www/chromium: . files References: <201301121859.r0CIxUld069366@slippy.cwsent.com> In-Reply-To: <201301121859.r0CIxUld069366@slippy.cwsent.com> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jan 2013 20:40:19 -0000 On 12-01-2013 19:59, Cy Schubert wrote: > In message <201301110114.r0B1Eq5P003555@svn.freebsd.org>, Rene Ladan writes: >> Author: rene >> Date: Fri Jan 11 01:14:52 2013 >> New Revision: 310215 >> URL: http://svnweb.freebsd.org/changeset/ports/310215 >> >> Log: >> Update to 24.0.1312.52, which add support for MathML. >> >> FreeBSD-specific improvements: >> - working WiFi geolocation [1] (can be turned off in preferences) >> - fix build with clang (use external libvpx) >> - use SysV SHM model and where possible OS_BSD, which saves some patches >> - no need to use ZygoteProcess switch >> >> HTML5 audio is currently broken. >> >> PR: ports/174402 [1] >> Submitted by: J.R. Oldroyd [1] >> Security: http://www.vuxml.org/freebsd/46bd747b-5b84-11e2-b06d-00262d5ed8 >> ee.html > [...] > > Hi Rene, > > It doesn't build. I don't have the actual error before me but the the > following patch resolves the issue. > > ===== cut here > --- media/filters/decrypting_audio_decoder.cc.orig 2013-01-07 > 18:40:10.000000000 -0800 > +++ media/filters/decrypting_audio_decoder.cc 2013-01-12 09:05:12.737640582 > -0800 > @@ -30,7 +30,7 @@ > // Out of sync of 100ms would be pretty noticeable and we should keep any > // drift below that. > const int64 kOutOfSyncThresholdInMicroseconds = 100000; > - return std::abs(timestamp_1.InMicroseconds() - timestamp_2.InMicroseconds > ()) > > + return std::labs(timestamp_1.InMicroseconds() - > timestamp_2.InMicroseconds()) > > kOutOfSyncThresholdInMicroseconds; > } > > ===== cut here > This looks like the error I got when building chromium on 8 or 9 with clang (from [1]): In file included from media/filters/decrypting_audio_decoder.cc:1: media/filters/decrypting_audio_decoder.cc:33:10: error: call to 'abs' is ambiguous return std::abs(timestamp_1.InMicroseconds() - timestamp_2.InMicroseconds()) > ^~~~~~~~ /usr/include/stdlib.h:83:5: note: candidate function int abs(int) __attribute__((__const__)); ^ /usr/include/c++/4.2/cstdlib:142:3: note: candidate function abs(long __i) { return labs(__i); } ^ 1 error generated. gmake: *** [out/Release/obj.target/media/media/filters/decrypting_audio_decoder.o] Error 1 I'll rebuild the port in my tinderbox with your patch. [1] http://rene-ladan.nl/tb/errors/9-FreeBSD/chromium-24.0.1312.45.log (8.0 MB)