From owner-freebsd-current  Mon Oct 14  2: 9:40 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8664937B401
	for <current@FreeBSD.ORG>; Mon, 14 Oct 2002 02:09:39 -0700 (PDT)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8CBF043E77
	for <current@FreeBSD.ORG>; Mon, 14 Oct 2002 02:09:38 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id TAA30929;
	Mon, 14 Oct 2002 19:09:21 +1000
Date: Mon, 14 Oct 2002 19:19:43 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Poul-Henning Kamp <phk@critter.freebsd.dk>
Cc: Jens Schweikhardt <schweikh@schweikhardt.net>,
	<current@FreeBSD.ORG>
Subject: Re: GEOM and NetBSD partitions/disklabels 
In-Reply-To: <7665.1034529873@critter.freebsd.dk>
Message-ID: <20021014190205.V829-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

On Sun, 13 Oct 2002, Poul-Henning Kamp wrote:

> In message <20021013172141.GA76272@schweikhardt.net>, Jens Schweikhardt writes:
> >On Sun, Oct 13, 2002 at 05:20:11PM +0200, Poul-Henning Kamp wrote:
>
> >In file included from /src/current/sys/geom/geom_bsd.c:62:
> >/src/current/sys/sys/disklabel.h:174: size of array `__assert174' is negative
> >*** Error code 1
> >
> >because of the compile time assert in disklabel.h,
> >
> >#ifdef CTASSERT
> >CTASSERT(sizeof(struct disklabel) == 276);
> >#endif
> Change this to:
>
> 	#ifdef CTASSERT
> 	CTASSERT(sizeof(struct disklabel) == 148 + 16 * MAXPARTITIONS);
> 	#endif
>
> >Another question before I adjust this to make it work: how will this
> >interact with devfs? My ultimate goal is to mount NetBSD partitions
> >on FreeBSD, e.g. /dev/da4s2[ae-p] (preferably read-write). There is
> >more work needed in a bunch of other files, right? If yes, could this
> >be a candidate for the JKH list?
>
> It should "just work", but I have never tried it :-)

This should just work for non-devfs non-geom too.  Only using labels
with more partitions than MAXPARTITIONS (as it was at compile time)
shouldn't work.  ISTR remember old breakage in disklabel(8) to make
it default to creating all MAXPARTITIONS partitions even when most of
them are empty.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message