From owner-p4-projects@FreeBSD.ORG  Wed Sep  5 05:17:36 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 3AD0516A41A; Wed,  5 Sep 2007 05:17:36 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0659F16A417;
	Wed,  5 Sep 2007 05:17:36 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id A194613C47E;
	Wed,  5 Sep 2007 05:17:35 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.1/8.13.4) with ESMTP id l855FdGh050617;
	Tue, 4 Sep 2007 23:15:40 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Tue, 04 Sep 2007 23:15:44 -0600 (MDT)
Message-Id: <20070904.231544.420517167.imp@bsdimp.com>
To: hselasky@c2i.net
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <200709041121.45990.hselasky@c2i.net>
References: <200709040755.l847tPbn003371@repoman.freebsd.org>
	<200709041121.45990.hselasky@c2i.net>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0
	(harmony.bsdimp.com [127.0.0.1]);
	Tue, 04 Sep 2007 23:15:40 -0600 (MDT)
Cc: perforce@freebsd.org, delphij@freebsd.org
Subject: Re: PERFORCE change 126033 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Sep 2007 05:17:36 -0000

In message: <200709041121.45990.hselasky@c2i.net>
            Hans Petter Selasky <hselasky@c2i.net> writes:
: Hi,
: 
: In my opinion you should keep braces around single line if's .
: 
: if (xxx) {
:    yyy;
: }
: 
: This will reduce the chance of error next time you add a statement to an if.

Sadly, or joyfully depending on your viewpoint, style(9) says you must
remove them.  Since we follow style(9) in this project it is better to
be uniform than to get the tiny bit of safety adding them gives.

Warner