From owner-svn-doc-all@FreeBSD.ORG Thu Jun 6 14:29:35 2013 Return-Path: Delivered-To: svn-doc-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id E8A035FD; Thu, 6 Jun 2013 14:29:35 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) by mx1.freebsd.org (Postfix) with ESMTP id D61C91703; Thu, 6 Jun 2013 14:29:34 +0000 (UTC) Received: from alph.d.allbsd.org (p2175-ipbf701funabasi.chiba.ocn.ne.jp [122.25.209.175]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id r56ETHfG018841 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 6 Jun 2013 23:29:27 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) (authenticated bits=0) by alph.d.allbsd.org (8.14.5/8.14.5) with ESMTP id r56ETEDq095164; Thu, 6 Jun 2013 23:29:16 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Thu, 06 Jun 2013 23:28:05 +0900 (JST) Message-Id: <20130606.232805.1823224325157138890.hrs@allbsd.org> To: gjb@FreeBSD.org Subject: Re: svn commit: r41848 - head/en_US.ISO8859-1/htdocs/layout/js From: Hiroki Sato In-Reply-To: <20130606140542.GA1625@glenbarber.us> References: <201306061149.r56BnrNn023865@svn.freebsd.org> <20130606140542.GA1625@glenbarber.us> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Thu_Jun__6_23_28_05_2013_413)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Thu, 06 Jun 2013 23:29:27 +0900 (JST) X-Spam-Status: No, score=-91.4 required=13.0 tests=CONTENT_TYPE_PRESENT, ONLY1HOPDIRECT,RCVD_IN_PBL,SAMEHELOBY2HOP,URI_OBFU_WWW,USER_IN_WHITELIST autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: wblock@wonkity.com, svn-doc-head@FreeBSD.org, svn-doc-all@FreeBSD.org, doc-committers@FreeBSD.org X-BeenThere: svn-doc-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire doc trees \(except for " user" , " projects" , and " translations" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jun 2013 14:29:36 -0000 ----Security_Multipart(Thu_Jun__6_23_28_05_2013_413)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Glen Barber wrote in <20130606140542.GA1625@glenbarber.us>: gj> On Thu, Jun 06, 2013 at 07:59:17AM -0600, Warren Block wrote: gj> > On Thu, 6 Jun 2013, Glen Barber wrote: gj> > gj> > >Author: gjb gj> > >Date: Thu Jun 6 11:49:53 2013 gj> > >New Revision: 41848 gj> > >URL: http://svnweb.freebsd.org/changeset/doc/41848 gj> > > gj> > >Log: gj> > > Check for boolean 'true' case of w.n.dNT. gj> > > gj> > > Submitted by: des gj> > > Approved by: doceng (implicit) gj> > > gj> > >Modified: gj> > > head/en_US.ISO8859-1/htdocs/layout/js/google.js gj> > > gj> > >Modified: head/en_US.ISO8859-1/htdocs/layout/js/google.js gj> > >============================================================================== gj> > >--- head/en_US.ISO8859-1/htdocs/layout/js/google.js Thu Jun 6 08:05:17 2013 (r41847) gj> > >+++ head/en_US.ISO8859-1/htdocs/layout/js/google.js Thu Jun 6 11:49:53 2013 (r41848) gj> > >@@ -18,7 +18,7 @@ var h = document.location.host; gj> > > */ gj> > >var fbsdregex = /((docs|security|svnweb|wiki|www)\.freebsd\.org|google\.com)/i; gj> > > gj> > >-if (window.navigator.doNotTrack === "yes") { gj> > >+if (window.navigator.doNotTrack == true) { gj> > > allow_track = false; gj> > >} gj> > gj> > Could that just be gj> > gj> > if (window.navigator.doNotTrack) { gj> > allow_track = false; gj> > } gj> gj> Not as far as I can tell. If DNT is not set, gj> window.navigator.doNotTrack is null, so it would evaluate to: gj> gj> if () { gj> allow_track = false; gj> } gj> gj> which I believe will always evaluate true. null, "", and undefined are evaluated as false in Javascript. -- Hiroki ----Security_Multipart(Thu_Jun__6_23_28_05_2013_413)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (FreeBSD) iEYEABECAAYFAlGwnHUACgkQTyzT2CeTzy2etgCeJlHNwVqQpKqXgkICpM6n6VEM p7AAoLVv/Y0qSQALFbprBAdpEVxdc9yz =XrUR -----END PGP SIGNATURE----- ----Security_Multipart(Thu_Jun__6_23_28_05_2013_413)----