From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Apr 4 08:50:04 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1D6891065675 for ; Mon, 4 Apr 2011 08:50:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C565E8FC15 for ; Mon, 4 Apr 2011 08:50:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p348o3au001341 for ; Mon, 4 Apr 2011 08:50:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p348o3XN001340; Mon, 4 Apr 2011 08:50:03 GMT (envelope-from gnats) Resent-Date: Mon, 4 Apr 2011 08:50:03 GMT Resent-Message-Id: <201104040850.p348o3XN001340@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Zhihao Yuan Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C98BC106564A for ; Mon, 4 Apr 2011 08:45:33 +0000 (UTC) (envelope-from lichray@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 8B5308FC12 for ; Mon, 4 Apr 2011 08:45:33 +0000 (UTC) Received: by iwn33 with SMTP id 33so6875522iwn.13 for ; Mon, 04 Apr 2011 01:45:33 -0700 (PDT) Received: by 10.42.29.5 with SMTP id p5mr9399190icc.454.1301906732182; Mon, 04 Apr 2011 01:45:32 -0700 (PDT) Received: from compaq.yuetime (c-98-228-191-105.hsd1.il.comcast.net [98.228.191.105]) by mx.google.com with ESMTPS id i26sm3613948iby.41.2011.04.04.01.45.29 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 04 Apr 2011 01:45:31 -0700 (PDT) Received: by compaq.yuetime (sSMTP sendmail emulation); Mon, 04 Apr 2011 03:45:26 -0500 Message-Id: <4d99852b.9aa5e70a.3dd0.ffffeb8c@mx.google.com> Date: Mon, 04 Apr 2011 03:45:26 -0500 From: Zhihao Yuan To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/156171: port multimedia/mplayer patch-libao2-ao_oss.c is incorrect X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Zhihao Yuan List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Apr 2011 08:50:04 -0000 >Number: 156171 >Category: ports >Synopsis: port multimedia/mplayer patch-libao2-ao_oss.c is incorrect >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Apr 04 08:50:03 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Zhihao Yuan >Release: FreeBSD 8.2-STABLE amd64 >Organization: Northern Illinois University >Environment: System: FreeBSD compaq.yuetime 8.2-STABLE FreeBSD 8.2-STABLE #0: Mon Mar 14 02:51:28 CDT 2011 root@compaq.yuetime:/usr/obj/usr/src/sys/HOUKAGO amd64 >Description: This patch moves the samplerate setting clause out of a condition block, which intends to make sure the samplerate is always set. But actually, there is another condition block at line 452, which makes these two blocks mutual exclusive. So, this patch is no needed. But! The author has reason to write the conditions like this! According to 4Front's document, http://www.4front-tech.com/pguide/audio.html the SNDCTLs must be set in this order: format, channels, sampling rate. So, this patch is incorrect. >How-To-Repeat: >Fix: Since the patch is unneeded and incorrect, please remove it. >Release-Note: >Audit-Trail: >Unformatted: