From owner-cvs-all@FreeBSD.ORG Mon May 26 07:31:03 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F2849106566C; Mon, 26 May 2008 07:31:02 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id B2D278FC17; Mon, 26 May 2008 07:31:02 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 72EB746C06; Mon, 26 May 2008 03:31:02 -0400 (EDT) Date: Mon, 26 May 2008 08:31:02 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: John Birrell In-Reply-To: <20080525221112.GH5179@what-creek.com> Message-ID: <20080526082614.C6489@fledge.watson.org> References: <200805250248.m4P2mv8U026913@repoman.freebsd.org> <20080525180014.S63463@fledge.watson.org> <20080525195955.GB5179@what-creek.com> <20080525225523.F36357@fledge.watson.org> <20080525221112.GH5179@what-creek.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, John Birrell , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 May 2008 07:31:03 -0000 On Sun, 25 May 2008, John Birrell wrote: > On Sun, May 25, 2008 at 11:00:40PM +0100, Robert Watson wrote: >> I think you should consider backing out the change -- the point of "make >> universe" is to build as much as we possibly can of the tree, including all >> variations on architectures, as many obscure kernel configurations as we >> can find, etc. People run make universe to confirm that their changes >> haven't broken the build for as many cases as possible, and sun4v remains a >> valid case to detect. > > I will back out the change, but I think you are making the 'universe' target > out to be more than was intended. We used to talk about tiers. We seem to > have lost sight of that. According to our tier documentation, sun4v is a tier 2 platform -- either on the way up, or on the way down, depending on how you look at it. All of the other tier 2 platforms, including ARM, PowerPC, ia64 and sparc64, appear in make universe, and I would expect objections if any of them were removed from make universe also. >> If you think we should write off sun4v at this point, which may well be a >> valid proposal, we should have the larger discussion about that before we >> remove it from make universe unless we have a pretty practical reason >> otherwise (i.e., dtrace and sun4v are fundamentally incompatible). > > This isn't related to DTrace. It's more about what builds developers are > expected to do before committing stuff. Much of the buildworld breakage over > the last month would have been detected if a universe build had been done. > Even the current breakage. Yes, sounds like people need to start running it before they commit major changes. And it's a cascading problem -- if people don't keep things building, it becomes much harder to build test further changes. Robert N M Watson Computer Laboratory University of Cambridge