From owner-freebsd-ports-bugs@FreeBSD.ORG Sat May 3 22:00:00 2014 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 99F693BC for ; Sat, 3 May 2014 22:00:00 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 73B451C18 for ; Sat, 3 May 2014 22:00:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s43M00Jj016510 for ; Sat, 3 May 2014 22:00:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s43M00xk016509; Sat, 3 May 2014 22:00:00 GMT (envelope-from gnats) Resent-Date: Sat, 3 May 2014 22:00:00 GMT Resent-Message-Id: <201405032200.s43M00xk016509@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Tijl Coosemans Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 486393B7 for ; Sat, 3 May 2014 21:59:50 +0000 (UTC) Received: from mailrelay002.isp.belgacom.be (mailrelay002.isp.belgacom.be [195.238.6.175]) by mx1.freebsd.org (Postfix) with ESMTP id DA03C1C13 for ; Sat, 3 May 2014 21:59:48 +0000 (UTC) Received: from 89.166-241-81.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([81.241.166.89]) by relay.skynet.be with ESMTP; 03 May 2014 23:59:40 +0200 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.8/8.14.8) with ESMTP id s43LxdSr082427 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Sat, 3 May 2014 23:59:39 +0200 (CEST) (envelope-from tijl@kalimero.tijl.coosemans.org) Received: (from tijl@localhost) by kalimero.tijl.coosemans.org (8.14.8/8.14.8/Submit) id s43Lxd50082426; Sat, 3 May 2014 23:59:39 +0200 (CEST) (envelope-from tijl) Message-Id: <201405032159.s43Lxd50082426@kalimero.tijl.coosemans.org> Date: Sat, 3 May 2014 23:59:39 +0200 (CEST) From: Tijl Coosemans To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.114 Subject: ports/189323: [patch] textproc/flex: make libfl_pic.a actually pic X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: Tijl Coosemans List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 May 2014 22:00:00 -0000 >Number: 189323 >Category: ports >Synopsis: [patch] textproc/flex: make libfl_pic.a actually pic >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat May 03 22:00:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Tijl Coosemans >Release: FreeBSD 11.0-CURRENT i386 >Organization: >Environment: >Description: Currently libfl_pic.a is compiled as a regular static library without -fpic so it is exactly the same as libfl.a. The attached patch modifies Makefile.am to add the -prefer-pic libtool flag. It also adds the --tag=disable-shared flag so a shared library is never built (it would be the same as libfl.so). This requires running automake which requires aclocal which in turn implies autoconf and autoheader. The RANLIB patching in post-patch is removed because it has no effect. The "tests" patching has been included in the Makefile.am patch because automake complains about the trailing backslash otherwise. The MAKEINFO patching is handled in CONFIGURE_ENV. This will be used to fix a problem in devel/libmatheval: https://redports.org/buildarchive/20140503201200-15078/ https://redports.org/buildarchive/20140503214120-38210/ Redports: https://redports.org/buildarchive/20140503214000-47181/ >How-To-Repeat: >Fix: --- flex.patch begins here --- Index: textproc/flex/Makefile =================================================================== --- textproc/flex/Makefile (revision 352934) +++ textproc/flex/Makefile (working copy) @@ -2,6 +2,7 @@ PORTNAME= flex PORTVERSION= 2.5.39 +PORTREVISION= 1 CATEGORIES= textproc MASTER_SITES= SF/${PORTNAME} @@ -12,11 +13,13 @@ BUILD_DEPENDS= help2man:${PORTSDIR}/misc gm4:${PORTSDIR}/devel/m4 RUN_DEPENDS= gm4:${PORTSDIR}/devel/m4 -USES= bison gmake tar:bzip2 +USES= bison gmake libtool:keepla tar:bzip2 +USE_AUTOTOOLS= aclocal autoconf autoheader automake +ACLOCAL_ARGS= -I m4 GNU_CONFIGURE= yes # install flex header to its own dir to avoid conflict with system flex. CONFIGURE_ARGS= --includedir=${PREFIX}/include/flex --disable-shared -CONFIGURE_ENV= M4=${LOCALBASE}/bin/gm4 +CONFIGURE_ENV= M4=${LOCALBASE}/bin/gm4 MAKEINFO="makeinfo --no-split" INSTALL_TARGET= install-strip INFO= flex @@ -27,12 +30,6 @@ NLS_USES= gettext iconv NLS_CONFIGURE_ENABLE= nls post-patch: .SILENT - ${REINPLACE_CMD} -Ee 's/tests//' \ - -e 's/^([[:space:]]*)\$$\(RANLIB\) ([^ ;]*)/\1chmod u+w \2;&/' \ - -e '/echo.*RANLIB/,+1d' \ - ${WRKSRC}/Makefile.in - ${REINPLACE_CMD} -e 's/@MAKEINFO@/& --no-split/g' \ - ${WRKSRC}/doc/Makefile.in ${RM} -f ${WRKSRC}/doc/*.info* .include Index: textproc/flex/files/patch-Makefile.am =================================================================== --- textproc/flex/files/patch-Makefile.am (revision 0) +++ textproc/flex/files/patch-Makefile.am (working copy) @@ -0,0 +1,21 @@ +--- Makefile.am.orig 2014-03-26 13:46:44.000000000 +0100 ++++ Makefile.am 2014-05-03 23:29:10.000000000 +0200 +@@ -79,6 +79,8 @@ + libmain.c \ + libyywrap.c + ++libfl_pic_la_CFLAGS = -prefer-pic ++libfl_pic_la_LIBTOOLFLAGS = --tag=disable-shared + libfl_pic_la_LDFLAGS = -no-undefined -version-info @SHARED_VERSION_INFO@ + + noinst_HEADERS = \ +@@ -119,8 +121,7 @@ + . \ + doc \ + examples \ +- po \ +- tests ++ po + + localedir = $(datadir)/locale + AM_CPPFLAGS = -DLOCALEDIR=\"$(localedir)\" -I$(top_srcdir)/intl Property changes on: textproc/flex/files/patch-Makefile.am ___________________________________________________________________ Added: fbsd:nokeywords ## -0,0 +1 ## +yes \ No newline at end of property Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property --- flex.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: