From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Jan 12 19:40:07 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5916316A41F for ; Thu, 12 Jan 2006 19:40:07 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 48DE943D55 for ; Thu, 12 Jan 2006 19:40:06 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k0CJe6FO020340 for ; Thu, 12 Jan 2006 19:40:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k0CJe66B020339; Thu, 12 Jan 2006 19:40:06 GMT (envelope-from gnats) Resent-Date: Thu, 12 Jan 2006 19:40:06 GMT Resent-Message-Id: <200601121940.k0CJe66B020339@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, NIIMI Satoshi Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 359FE16A41F for ; Thu, 12 Jan 2006 19:31:46 +0000 (GMT) (envelope-from sa2c@sa2c.net) Received: from sakura.and.or.jp (sakura.and.or.jp [59.106.20.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id CE5BC43D45 for ; Thu, 12 Jan 2006 19:31:45 +0000 (GMT) (envelope-from sa2c@sa2c.net) Received: from sakura.and.or.jp (localhost [127.0.0.1]) by sakura.and.or.jp (Postfix) with ESMTP id 55A7661C29 for ; Fri, 13 Jan 2006 04:31:40 +0900 (JST) Received: from berkeley.l.sa2c.net (berkeley.vpn.and.or.jp [10.46.49.3]) by sakura.and.or.jp (Postfix) with ESMTP id 32B8761C25 for ; Fri, 13 Jan 2006 04:31:40 +0900 (JST) Received: by berkeley.l.sa2c.net (Postfix, from userid 3104) id 22E3B11456; Fri, 13 Jan 2006 04:31:40 +0900 (JST) Message-Id: <20060112193140.22E3B11456@berkeley.l.sa2c.net> Date: Fri, 13 Jan 2006 04:31:40 +0900 (JST) From: NIIMI Satoshi To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/91721: mail/postfix: "etc/rc.d/postfix.sh restart" may fail X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: NIIMI Satoshi List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2006 19:40:07 -0000 >Number: 91721 >Category: ports >Synopsis: mail/postfix: "etc/rc.d/postfix.sh restart" may fail >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Jan 12 19:40:05 GMT 2006 >Closed-Date: >Last-Modified: >Originator: NIIMI Satoshi >Release: FreeBSD 6.0-RELEASE-p2 i386 >Organization: >Environment: System: FreeBSD berkeley.l.sa2c.net 6.0-RELEASE-p2 FreeBSD 6.0-RELEASE-p2 #1: Wed Jan 11 18:32:57 JST 2006 root@berkeley.l.sa2c.net:/usr/obj/usr/src/sys/GENERIC i386 >Description: Running "${PREFIX}/etc/rc.d/postfix.sh restart" may produce an error postfix/postfix-script: fatal: the Postfix mail system is already running if "postfix stop" takes some time. It is because the postfix(8) command just sends a signal to the master(8) daemon and does not wait the process to be stopped. The PID file should be checked to restart the daemon reliably. >How-To-Repeat: >Fix: --- postfix.diff begins here --- Index: Makefile =================================================================== RCS file: /home/ncvs/ports/mail/postfix/Makefile,v retrieving revision 1.105 diff -u -r1.105 Makefile --- Makefile 12 Jan 2006 16:23:59 -0000 1.105 +++ Makefile 12 Jan 2006 19:17:27 -0000 @@ -16,7 +16,7 @@ PORTNAME= postfix PORTVERSION= 2.2.8 -PORTREVISION= 1 +PORTREVISION= 2 PORTEPOCH= 1 CATEGORIES= mail ipv6 MASTER_SITES= ftp://ftp.porcupine.org/mirrors/postfix-release/official/ \ Index: files/postfix.sh.in =================================================================== RCS file: /home/ncvs/ports/mail/postfix/files/postfix.sh.in,v retrieving revision 1.1 diff -u -r1.1 postfix.sh.in --- files/postfix.sh.in 12 Jan 2006 16:23:59 -0000 1.1 +++ files/postfix.sh.in 12 Jan 2006 19:15:46 -0000 @@ -14,6 +14,8 @@ # DO NOT CHANGE THESE DEFAULT VALUES HERE # postfix_enable="${postfix_enable-NO}" +postfix_pidfile="${postfix_pidfile:-/var/spool/postfix/pid/master.pid}" +postfix_procname="${postfix_procname:-/usr/local/libexec/postfix/master}" . %%RC_SUBR%% @@ -23,6 +25,9 @@ start_cmd=${name}_start stop_cmd=${name}_stop +pidfile=${postfix_pidfile} +procname=${postfix_procname} + postfix_start() { %%PREFIX%%/sbin/postfix start } --- postfix.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: