From owner-freebsd-current@FreeBSD.ORG Sat Jun 26 04:10:31 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 22CC916A4CE; Sat, 26 Jun 2004 04:10:31 +0000 (GMT) Received: from transport.cksoft.de (transport.cksoft.de [62.111.66.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6C8AF43D1F; Sat, 26 Jun 2004 04:10:30 +0000 (GMT) (envelope-from bzeeb+freebsd@zabbadoz.net) Received: from transport.cksoft.de (localhost [127.0.0.1]) by transport.cksoft.de (Postfix) with ESMTP id 629461FFDDD; Sat, 26 Jun 2004 06:10:09 +0200 (CEST) Received: by transport.cksoft.de (Postfix, from userid 66) id 34C021FFDDB; Sat, 26 Jun 2004 06:10:07 +0200 (CEST) Received: by mail.int.zabbadoz.net (Postfix, from userid 1060) id 2AB4E15384; Sat, 26 Jun 2004 04:07:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.int.zabbadoz.net (Postfix) with ESMTP id 1E8FF15380; Sat, 26 Jun 2004 04:07:48 +0000 (UTC) Date: Sat, 26 Jun 2004 04:07:47 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@e0-0.zab2.int.zabbadoz.net To: Julian Elischer In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS cksoft-s20020300-20031204bz on transport.cksoft.de X-Mailman-Approved-At: Sat, 26 Jun 2004 11:48:36 +0000 cc: pjd@FreeBSD.org cc: FreeBSD current users cc: bzeeb+freebsd@zabbadoz.net Subject: Re: jail getfsstat patches. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jun 2004 04:10:31 -0000 On Fri, 25 Jun 2004, Julian Elischer wrote: Hi, [somewhat early and not realy awake but will be away the next hours so here is some input] > There are patches around to make 'df' and 'mount' > show pretty much the exact right thing from a jail. > I propose to commit these. *yippie* I know a lot of people that will be happy :-))) > http://sources.zabbadoz.net/freebsd/jail.html > for 5.x > > with possible small changes.. there are currently one to two minor bugs I have found while testing this on 5.2.1-p8 on the version that is available; I have a newer version here internally with one of the problems fixed. No problem is too serious so anything would crash or panic. The version has been workin on production systems since releasing now. The first one is that one of the '/' was misplaced by a copy and paste error and you would see s.th. like /dev/ad0s2f 1972750 123014 1691916 7% instead of /dev/ad0s2f 1972750 123014 1691916 7% / The other is that if you have two jails at /jail-abc and /jail-abcdefg you will see something like /dev/ad0s2f 1972750 123014 1691916 7% defg in /jail-abc; I think this problem might exist in more of the versions I had seen. I am about to fix this but I will be away this weekend. I might find the time on sunday eve. For a FreebSD4-Version: I do not have a patch for that but there have been other PRs (at least one from Oliver Fromme, PR47586) and there has been a private patch from Chrisitian Kratzer (but still w/o any sysctl). An older version of my patch should be more easy to MFC (had been done before the statfs changes) if you want that. > Does anyone violently object to these? not me; but -current has that sysctl people get pointed to and all the related PRs got either ignored and closed for months now - so the question would be: do other comitters welcome this ? As said; I know a lot of people who would really like it... -- Greetings Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT