From owner-freebsd-doc@FreeBSD.ORG Mon Feb 21 12:00:46 2005 Return-Path: Delivered-To: freebsd-doc@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C2DF916A4D0 for ; Mon, 21 Feb 2005 12:00:46 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 555FD43D5F for ; Mon, 21 Feb 2005 12:00:46 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id j1LC0cW8043873 for ; Mon, 21 Feb 2005 12:00:38 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.1/8.13.1/Submit) id j1LC0ct0043870; Mon, 21 Feb 2005 12:00:38 GMT (envelope-from gnats) Resent-Date: Mon, 21 Feb 2005 12:00:38 GMT Resent-Message-Id: <200502211200.j1LC0ct0043870@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-doc@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Florent Thoumie Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C525A16A4CE for ; Mon, 21 Feb 2005 11:57:46 +0000 (GMT) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6C92243D53 for ; Mon, 21 Feb 2005 11:57:46 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id 0A8EA1162D for ; Mon, 21 Feb 2005 12:59:21 +0100 (CET) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 81236-07 for ; Mon, 21 Feb 2005 12:59:15 +0100 (CET) Received: by smtp.xbsd.org (Postfix, from userid 2001) id 8BB0C1161B; Mon, 21 Feb 2005 12:59:15 +0100 (CET) Message-Id: <20050221115915.8BB0C1161B@smtp.xbsd.org> Date: Mon, 21 Feb 2005 12:59:15 +0100 (CET) From: Florent Thoumie To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: docs/77851: articles/committers-guide: change Approved -> Reviewed X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Florent Thoumie List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Feb 2005 12:00:47 -0000 >Number: 77851 >Category: docs >Synopsis: articles/committers-guide: change Approved -> Reviewed >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-doc >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Feb 21 12:00:38 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Florent Thoumie >Release: FreeBSD 5.3-RELEASE i386 >Organization: Xbsd.org >Environment: System: FreeBSD srv1.xbsd.org 5.3-RELEASE FreeBSD 5.3-RELEASE #2: Wed Nov 24 16:35:34 CET 2004 root@gate.xbsd.org:/usr/src/sys/i386/compile/GATE i386 >Description: These are two different statements of the Committer's Guide. I think the second one is erroneous. "Approved by" is only acceptable from non-mentored src committers -- mentored committers can provide a "Reviewed by" but not an "Approved by". Until your mentor decides (and announces with a forced commit to access) that you have learned the ropes and are ready to commit on your own, you should not commit anything without first getting your mentor's review and approval, and you should document that approval with an Approved by: line in the commit message. >How-To-Repeat: >Fix: --- article.sgml.diff begins here --- Index: article.sgml =================================================================== RCS file: /home/ncvs/doc/en_US.ISO8859-1/articles/committers-guide/article.sgml,v retrieving revision 1.219 diff -u -r1.219 article.sgml --- article.sgml 22 Dec 2004 07:54:15 -0000 1.219 +++ article.sgml 21 Feb 2005 11:47:19 -0000 @@ -1148,7 +1148,7 @@ ropes and are ready to commit on your own, you should not commit anything without first getting your mentor's review and approval, and you should document that approval with an - Approved by: line in the commit + Reviewed by: line in the commit message. All src commits should go to --- article.sgml.diff ends here--- >Release-Note: >Audit-Trail: >Unformatted: