From owner-svn-src-all@FreeBSD.ORG Sat Jul 7 01:12:10 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A82E2106566B; Sat, 7 Jul 2012 01:12:10 +0000 (UTC) (envelope-from marcel@xcllnt.net) Received: from mail.xcllnt.net (mail.xcllnt.net [70.36.220.4]) by mx1.freebsd.org (Postfix) with ESMTP id 6F7AE8FC0A; Sat, 7 Jul 2012 01:12:10 +0000 (UTC) Received: from dhcp-192-168-2-58.wifi.xcllnt.net (wifi.xcllnt.net [70.36.220.6] (may be forged)) (authenticated bits=0) by mail.xcllnt.net (8.14.5/8.14.5) with ESMTP id q671Bt2Y056896 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Fri, 6 Jul 2012 18:12:03 -0700 (PDT) (envelope-from marcel@xcllnt.net) Mime-Version: 1.0 (Apple Message framework v1278) Content-Type: text/plain; charset=us-ascii From: Marcel Moolenaar In-Reply-To: <20120706181213.GI2338@deviant.kiev.zoral.com.ua> Date: Fri, 6 Jul 2012 18:11:56 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201207061557.q66Fv45N069464@svn.freebsd.org> <20120706181213.GI2338@deviant.kiev.zoral.com.ua> To: Konstantin Belousov X-Mailer: Apple Mail (2.1278) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Marcel Moolenaar , src-committers@freebsd.org Subject: Re: svn commit: r238172 - head/sys/dev/agp X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jul 2012 01:12:10 -0000 On Jul 6, 2012, at 11:12 AM, Konstantin Belousov wrote: >> agp_i810.c: >> While arguably the use of Maxmem can be considered correct, replace = its use >> with realmem anyway. agp_i810.c is specific to amd64, i386 & pc98, = which >> have a dense physical memory layout. Avoiding Maxmem here is done = with an >> eye on copy-n-paste behaviour in general and to avoid confusion = caused by >> using realmem in agp.c and Maxmem in agp_i810.c. > The agp_i810.c use is to prevent attachment when largest physical = address > of populated memory exceeds GPU limits established by PTE format and > chipset errata. Editing Maxmem to be spelled as realmem seems to = change > nothing right now, but I do argue that this is wrong, and commit = message > makes future archeology quite confusing. The commit log states it all, including how one can arguably call the = change wrong. What exactly is confusing? --=20 Marcel Moolenaar marcel@xcllnt.net