From owner-p4-projects@FreeBSD.ORG  Mon Apr  7 14:20:29 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id F320B37B404; Mon,  7 Apr 2003 14:20:28 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8115737B401
	for <perforce@freebsd.org>; Mon,  7 Apr 2003 14:20:28 -0700 (PDT)
Received: from mail.speakeasy.net (mail11.speakeasy.net [216.254.0.211])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 845D743FBF
	for <perforce@freebsd.org>; Mon,  7 Apr 2003 14:20:27 -0700 (PDT)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 22168 invoked from network); 7 Apr 2003 21:20:35 -0000
Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63])
	(envelope-sender <jhb@FreeBSD.org>)encrypted SMTP
	for <perforce@freebsd.org>; 7 Apr 2003 21:20:35 -0000
Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1])
	by server.baldwin.cx (8.12.8/8.12.8) with ESMTP id h37LKPOv043914;
	Mon, 7 Apr 2003 17:20:25 -0400 (EDT)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.20030407162026.jhb@FreeBSD.org>
X-Mailer: XFMail 1.5.4 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <200304050333.h353XRdE099823@repoman.freebsd.org>
Date: Mon, 07 Apr 2003 16:20:26 -0400 (EDT)
From: John Baldwin <jhb@FreeBSD.org>
To: Peter Wemm <peter@FreeBSD.org>
cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: RE: PERFORCE change 28149 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Apr 2003 21:20:30 -0000


On 05-Apr-2003 Peter Wemm wrote:
> http://perforce.freebsd.org/chv.cgi?CH=28149
> 
> Change 28149 by peter@peter_overcee on 2003/04/04 19:32:58
> 
>       oops. s/l/q/ in write_rflags()
> 
> Affected files ...
> 
> .. //depot/projects/hammer/sys/x86_64/include/cpufunc.h#7 edit
> 
> Differences ...
> 
> ==== //depot/projects/hammer/sys/x86_64/include/cpufunc.h#7 (text+ko) ====
> 
> @@ -357,7 +357,7 @@
>  static __inline void
>  write_rflags(u_long ef)

On an unrelated topic:

A lot of these cpufunc things should use register_t rather than int
or long.  This would have slightly simplified porting them to hammer
and reduce the diffs.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/